Re: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-08 Thread Vitaly Kuznetsov
"Michael Kelley (EOSG)" writes: >> >> > Removing definitions from userspace api isn't a good idea. >> >> > >> >> > I have no idea why hyper.h is a userspace api, though -- Linux doesn't >> >> > define any of those, so we could copy the definitions to a private >>

Re: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-08 Thread Vitaly Kuznetsov
"Michael Kelley (EOSG)" writes: >> >> > Removing definitions from userspace api isn't a good idea. >> >> > >> >> > I have no idea why hyper.h is a userspace api, though -- Linux doesn't >> >> > define any of those, so we could copy the definitions to a private >> >> > header, rename, and never

RE: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-08 Thread Michael Kelley (EOSG)
> >> > Removing definitions from userspace api isn't a good idea. > >> > > >> > I have no idea why hyper.h is a userspace api, though -- Linux doesn't > >> > define any of those, so we could copy the definitions to a private > >> > header, rename, and never look at this file again. > >> > >> That

RE: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-08 Thread Michael Kelley (EOSG)
> >> > Removing definitions from userspace api isn't a good idea. > >> > > >> > I have no idea why hyper.h is a userspace api, though -- Linux doesn't > >> > define any of those, so we could copy the definitions to a private > >> > header, rename, and never look at this file again. > >> > >> That

Re: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-08 Thread Vitaly Kuznetsov
Radim Krčmář writes: > 2018-03-07 19:48+0300, Roman Kagan: >> On Wed, Mar 07, 2018 at 05:19:44PM +0100, Radim Krčmář wrote: >> > 2018-02-26 18:11+0100, Vitaly Kuznetsov: >> > > diff --git a/arch/x86/include/uapi/asm/hyperv.h >> > > b/arch/x86/include/uapi/asm/hyperv.h >> > >

Re: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-08 Thread Vitaly Kuznetsov
Radim Krčmář writes: > 2018-03-07 19:48+0300, Roman Kagan: >> On Wed, Mar 07, 2018 at 05:19:44PM +0100, Radim Krčmář wrote: >> > 2018-02-26 18:11+0100, Vitaly Kuznetsov: >> > > diff --git a/arch/x86/include/uapi/asm/hyperv.h >> > > b/arch/x86/include/uapi/asm/hyperv.h >> > > @@ -275,10 +275,10

Re: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-07 Thread Radim Krčmář
2018-03-07 19:48+0300, Roman Kagan: > On Wed, Mar 07, 2018 at 05:19:44PM +0100, Radim Krčmář wrote: > > 2018-02-26 18:11+0100, Vitaly Kuznetsov: > > > diff --git a/arch/x86/include/uapi/asm/hyperv.h > > > b/arch/x86/include/uapi/asm/hyperv.h > > > @@ -275,10 +275,10 @@ struct

Re: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-07 Thread Radim Krčmář
2018-03-07 19:48+0300, Roman Kagan: > On Wed, Mar 07, 2018 at 05:19:44PM +0100, Radim Krčmář wrote: > > 2018-02-26 18:11+0100, Vitaly Kuznetsov: > > > diff --git a/arch/x86/include/uapi/asm/hyperv.h > > > b/arch/x86/include/uapi/asm/hyperv.h > > > @@ -275,10 +275,10 @@ struct

Re: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-07 Thread Roman Kagan
On Wed, Mar 07, 2018 at 05:19:44PM +0100, Radim Krčmář wrote: > 2018-02-26 18:11+0100, Vitaly Kuznetsov: > > From: Ladi Prosek > > > > The assist page has been used only for the paravirtual EOI so far, hence > > the "APIC" in the MSR name. Renaming to match the Hyper-V TLFS

Re: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-07 Thread Roman Kagan
On Wed, Mar 07, 2018 at 05:19:44PM +0100, Radim Krčmář wrote: > 2018-02-26 18:11+0100, Vitaly Kuznetsov: > > From: Ladi Prosek > > > > The assist page has been used only for the paravirtual EOI so far, hence > > the "APIC" in the MSR name. Renaming to match the Hyper-V TLFS where it's > > called

Re: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-07 Thread Radim Krčmář
2018-02-26 18:11+0100, Vitaly Kuznetsov: > From: Ladi Prosek > > The assist page has been used only for the paravirtual EOI so far, hence > the "APIC" in the MSR name. Renaming to match the Hyper-V TLFS where it's > called "Virtual VP Assist MSR". > > Signed-off-by: Ladi

Re: [PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-03-07 Thread Radim Krčmář
2018-02-26 18:11+0100, Vitaly Kuznetsov: > From: Ladi Prosek > > The assist page has been used only for the paravirtual EOI so far, hence > the "APIC" in the MSR name. Renaming to match the Hyper-V TLFS where it's > called "Virtual VP Assist MSR". > > Signed-off-by: Ladi Prosek >

[PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-02-26 Thread Vitaly Kuznetsov
From: Ladi Prosek The assist page has been used only for the paravirtual EOI so far, hence the "APIC" in the MSR name. Renaming to match the Hyper-V TLFS where it's called "Virtual VP Assist MSR". Signed-off-by: Ladi Prosek Signed-off-by: Vitaly

[PATCH v2 1/5] x86/kvm: rename HV_X64_MSR_APIC_ASSIST_PAGE to HV_X64_MSR_VP_ASSIST_PAGE

2018-02-26 Thread Vitaly Kuznetsov
From: Ladi Prosek The assist page has been used only for the paravirtual EOI so far, hence the "APIC" in the MSR name. Renaming to match the Hyper-V TLFS where it's called "Virtual VP Assist MSR". Signed-off-by: Ladi Prosek Signed-off-by: Vitaly Kuznetsov ---