Re: [PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-04-03 Thread Andi Kleen
On Thu, Apr 03, 2014 at 08:43:37AM +0200, Ingo Molnar wrote: > > * Igor Mammedov wrote: > > > > I've seen that. Kernel still boots. With your patch it would hang. > > Nonsense, not booting is OK when critical hardware is genuinely bad - > this isn't a disk drive or networking where bad IO

Re: [PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-04-03 Thread Ingo Molnar
* Igor Mammedov wrote: > > I've seen that. Kernel still boots. With your patch it would hang. Nonsense, not booting is OK when critical hardware is genuinely bad - this isn't a disk drive or networking where bad IO 'happens sometimes' and failure is something we have to engineer for - this

Re: [PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-04-03 Thread Andi Kleen
On Thu, Apr 03, 2014 at 08:43:37AM +0200, Ingo Molnar wrote: * Igor Mammedov imamm...@redhat.com wrote: I've seen that. Kernel still boots. With your patch it would hang. Nonsense, not booting is OK when critical hardware is genuinely bad - this isn't a disk drive or networking where

Re: [PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-04-03 Thread Ingo Molnar
* Igor Mammedov imamm...@redhat.com wrote: I've seen that. Kernel still boots. With your patch it would hang. Nonsense, not booting is OK when critical hardware is genuinely bad - this isn't a disk drive or networking where bad IO 'happens sometimes' and failure is something we have to

Re: [PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-04-02 Thread Andi Kleen
On Wed, Apr 02, 2014 at 11:29:56PM +0200, Igor Mammedov wrote: > On Wed, 02 Apr 2014 10:15:29 -0700 > Andi Kleen wrote: > > > Igor Mammedov writes: > > > > > Hang is observed on virtual machines during CPU hotplug, > > > especially in big guests with many CPUs. (It reproducible > > > more

Re: [PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-04-02 Thread Igor Mammedov
On Wed, 02 Apr 2014 10:15:29 -0700 Andi Kleen wrote: > Igor Mammedov writes: > > > Hang is observed on virtual machines during CPU hotplug, > > especially in big guests with many CPUs. (It reproducible > > more often if host is over-committed). > > > > It happens because master CPU gives up

Re: [PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-04-02 Thread Andi Kleen
Igor Mammedov writes: > Hang is observed on virtual machines during CPU hotplug, > especially in big guests with many CPUs. (It reproducible > more often if host is over-committed). > > It happens because master CPU gives up waiting on > secondary CPU and allows it to run wild. As result > AP

Re: [PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-04-02 Thread Andi Kleen
Igor Mammedov imamm...@redhat.com writes: Hang is observed on virtual machines during CPU hotplug, especially in big guests with many CPUs. (It reproducible more often if host is over-committed). It happens because master CPU gives up waiting on secondary CPU and allows it to run wild. As

Re: [PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-04-02 Thread Igor Mammedov
On Wed, 02 Apr 2014 10:15:29 -0700 Andi Kleen a...@firstfloor.org wrote: Igor Mammedov imamm...@redhat.com writes: Hang is observed on virtual machines during CPU hotplug, especially in big guests with many CPUs. (It reproducible more often if host is over-committed). It happens

Re: [PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-04-02 Thread Andi Kleen
On Wed, Apr 02, 2014 at 11:29:56PM +0200, Igor Mammedov wrote: On Wed, 02 Apr 2014 10:15:29 -0700 Andi Kleen a...@firstfloor.org wrote: Igor Mammedov imamm...@redhat.com writes: Hang is observed on virtual machines during CPU hotplug, especially in big guests with many CPUs. (It

[PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-03-31 Thread Igor Mammedov
Hang is observed on virtual machines during CPU hotplug, especially in big guests with many CPUs. (It reproducible more often if host is over-committed). It happens because master CPU gives up waiting on secondary CPU and allows it to run wild. As result AP causes locking or crashing system. For

[PATCH v2 1/5] x86: replace timeouts when booting secondary CPU with infinite wait loop

2014-03-31 Thread Igor Mammedov
Hang is observed on virtual machines during CPU hotplug, especially in big guests with many CPUs. (It reproducible more often if host is over-committed). It happens because master CPU gives up waiting on secondary CPU and allows it to run wild. As result AP causes locking or crashing system. For