Re: [PATCH v2 1/6] ARM: OMAP4: PRM: Remove hardcoding of PRM_IO_PMCTRL_OFFSET register

2015-07-15 Thread Keerthy
Paul, Thanks for the review! On Thursday 16 July 2015 07:24 AM, Paul Walmsley wrote: Hi a few minor comments On Wed, 8 Jul 2015, Keerthy wrote: PRM_IO_PMCTRL_OFFSET need not be same for all SOCs hence remove hardcoding and use the value provided by the omap_prcm_irq_setup structure.

Re: [PATCH v2 1/6] ARM: OMAP4: PRM: Remove hardcoding of PRM_IO_PMCTRL_OFFSET register

2015-07-15 Thread Paul Walmsley
Hi a few minor comments On Wed, 8 Jul 2015, Keerthy wrote: > PRM_IO_PMCTRL_OFFSET need not be same for all SOCs hence > remove hardcoding and use the value provided by the omap_prcm_irq_setup > structure. Please mention here that the reason why you're making this change is to support AM437x.

Re: [PATCH v2 1/6] ARM: OMAP4: PRM: Remove hardcoding of PRM_IO_PMCTRL_OFFSET register

2015-07-15 Thread Keerthy
Paul, Thanks for the review! On Thursday 16 July 2015 07:24 AM, Paul Walmsley wrote: Hi a few minor comments On Wed, 8 Jul 2015, Keerthy wrote: PRM_IO_PMCTRL_OFFSET need not be same for all SOCs hence remove hardcoding and use the value provided by the omap_prcm_irq_setup structure.

Re: [PATCH v2 1/6] ARM: OMAP4: PRM: Remove hardcoding of PRM_IO_PMCTRL_OFFSET register

2015-07-15 Thread Paul Walmsley
Hi a few minor comments On Wed, 8 Jul 2015, Keerthy wrote: PRM_IO_PMCTRL_OFFSET need not be same for all SOCs hence remove hardcoding and use the value provided by the omap_prcm_irq_setup structure. Please mention here that the reason why you're making this change is to support AM437x.

[PATCH v2 1/6] ARM: OMAP4: PRM: Remove hardcoding of PRM_IO_PMCTRL_OFFSET register

2015-07-07 Thread Keerthy
PRM_IO_PMCTRL_OFFSET need not be same for all SOCs hence remove hardcoding and use the value provided by the omap_prcm_irq_setup structure. Signed-off-by: Keerthy --- arch/arm/mach-omap2/prcm-common.h | 1 + arch/arm/mach-omap2/prm44xx.c | 11 ++- 2 files changed, 7 insertions(+),

[PATCH v2 1/6] ARM: OMAP4: PRM: Remove hardcoding of PRM_IO_PMCTRL_OFFSET register

2015-07-07 Thread Keerthy
PRM_IO_PMCTRL_OFFSET need not be same for all SOCs hence remove hardcoding and use the value provided by the omap_prcm_irq_setup structure. Signed-off-by: Keerthy j-keer...@ti.com --- arch/arm/mach-omap2/prcm-common.h | 1 + arch/arm/mach-omap2/prm44xx.c | 11 ++- 2 files changed, 7