Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-13 Thread Matt Porter
On Tue, Nov 26, 2013 at 04:22:23PM -0800, Marc Carino wrote: > The BCM7xxx series of Broadcom SoCs are used primarily in set-top boxes. > > This patch adds machine support for the ARM-based Broadcom SoCs. > > Signed-off-by: Marc Carino > Acked-by: Florian Fainelli > diff --git

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-13 Thread Matt Porter
On Tue, Nov 26, 2013 at 04:22:23PM -0800, Marc Carino wrote: The BCM7xxx series of Broadcom SoCs are used primarily in set-top boxes. This patch adds machine support for the ARM-based Broadcom SoCs. Signed-off-by: Marc Carino marc.cee...@gmail.com Acked-by: Florian Fainelli

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-06 Thread Arnd Bergmann
On Friday 06 December 2013, Florian Fainelli wrote: > This BCHP_IRQ0 register is kind of special and only acts as an > interrupt forwarder. Not enabling the IRQEN bit will prevent the UART > interrupts to be raised at the GIC level. Now that I think about this > some more, we might just go with

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-06 Thread Florian Fainelli
2013/12/5 Arnd Bergmann : > On Thursday 05 December 2013, Florian Fainelli wrote: >> 2013/12/3 Arnd Bergmann : >> > >> >> + addr = ioremap(BPHYSADDR(BCHP_IRQ0_IRQEN), sizeof(u32)); >> >> + writel_relaxed(BCHP_IRQ0_IRQEN_uarta_irqen_MASK >> >> + |

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-06 Thread Arnd Bergmann
On Friday 06 December 2013, Marc C wrote: > > This seems like stuff that should go into the device drivers for the > > respective hardware blocks, not into platform code. > > Understood. I'm not sure if you recall this [1] conversation, but short > of having a big array of registers offsets per

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-06 Thread Arnd Bergmann
On Friday 06 December 2013, Marc C wrote: This seems like stuff that should go into the device drivers for the respective hardware blocks, not into platform code. Understood. I'm not sure if you recall this [1] conversation, but short of having a big array of registers offsets per chip ID

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-06 Thread Florian Fainelli
2013/12/5 Arnd Bergmann a...@arndb.de: On Thursday 05 December 2013, Florian Fainelli wrote: 2013/12/3 Arnd Bergmann a...@arndb.de: + addr = ioremap(BPHYSADDR(BCHP_IRQ0_IRQEN), sizeof(u32)); + writel_relaxed(BCHP_IRQ0_IRQEN_uarta_irqen_MASK + |

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-06 Thread Arnd Bergmann
On Friday 06 December 2013, Florian Fainelli wrote: This BCHP_IRQ0 register is kind of special and only acts as an interrupt forwarder. Not enabling the IRQEN bit will prevent the UART interrupts to be raised at the GIC level. Now that I think about this some more, we might just go with some

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-05 Thread Marc C
Hello Arnd, > Do you have a strong reason to have your own defconfig file? We > currently try to consolidate as much as possible into > multi_v7_defconfig, so please see if you can extend that instead to > do what you need. There's no reason why we can't use the multi-platform defconfig. I'll

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-05 Thread Arnd Bergmann
On Thursday 05 December 2013, Florian Fainelli wrote: > 2013/12/3 Arnd Bergmann : > > > >> + addr = ioremap(BPHYSADDR(BCHP_IRQ0_IRQEN), sizeof(u32)); > >> + writel_relaxed(BCHP_IRQ0_IRQEN_uarta_irqen_MASK > >> + | BCHP_IRQ0_IRQEN_uartb_irqen_MASK > >> + |

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-05 Thread Florian Fainelli
Hi Arnd, 2013/12/3 Arnd Bergmann : > >> + addr = ioremap(BPHYSADDR(BCHP_IRQ0_IRQEN), sizeof(u32)); >> + writel_relaxed(BCHP_IRQ0_IRQEN_uarta_irqen_MASK >> + | BCHP_IRQ0_IRQEN_uartb_irqen_MASK >> + | BCHP_IRQ0_IRQEN_uartc_irqen_MASK, addr); >> + iounmap(addr); >

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-05 Thread Florian Fainelli
Hi Arnd, 2013/12/3 Arnd Bergmann a...@arndb.de: + addr = ioremap(BPHYSADDR(BCHP_IRQ0_IRQEN), sizeof(u32)); + writel_relaxed(BCHP_IRQ0_IRQEN_uarta_irqen_MASK + | BCHP_IRQ0_IRQEN_uartb_irqen_MASK + | BCHP_IRQ0_IRQEN_uartc_irqen_MASK, addr); + iounmap(addr);

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-05 Thread Arnd Bergmann
On Thursday 05 December 2013, Florian Fainelli wrote: 2013/12/3 Arnd Bergmann a...@arndb.de: + addr = ioremap(BPHYSADDR(BCHP_IRQ0_IRQEN), sizeof(u32)); + writel_relaxed(BCHP_IRQ0_IRQEN_uarta_irqen_MASK + | BCHP_IRQ0_IRQEN_uartb_irqen_MASK + |

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-05 Thread Marc C
Hello Arnd, Do you have a strong reason to have your own defconfig file? We currently try to consolidate as much as possible into multi_v7_defconfig, so please see if you can extend that instead to do what you need. There's no reason why we can't use the multi-platform defconfig. I'll make

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-03 Thread Arnd Bergmann
On Wednesday 27 November 2013, Marc Carino wrote: > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index 5765abf..266c699 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -94,6 +94,17 @@ choice > depends on ARCH_BCM2835 > select

Re: [PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-12-03 Thread Arnd Bergmann
On Wednesday 27 November 2013, Marc Carino wrote: diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 5765abf..266c699 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -94,6 +94,17 @@ choice depends on ARCH_BCM2835 select

[PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-11-26 Thread Marc Carino
The BCM7xxx series of Broadcom SoCs are used primarily in set-top boxes. This patch adds machine support for the ARM-based Broadcom SoCs. Signed-off-by: Marc Carino Acked-by: Florian Fainelli --- arch/arm/Kconfig.debug | 16 +++- arch/arm/configs/brcmstb_defconfig | 127

[PATCH v2 1/6] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2013-11-26 Thread Marc Carino
The BCM7xxx series of Broadcom SoCs are used primarily in set-top boxes. This patch adds machine support for the ARM-based Broadcom SoCs. Signed-off-by: Marc Carino marc.cee...@gmail.com Acked-by: Florian Fainelli f.faine...@gmail.com --- arch/arm/Kconfig.debug | 16 +++-