Re: [PATCH v2 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-13 Thread Antoine Ténart
On Mon, May 12, 2014 at 11:16:52AM +0200, Antoine Ténart wrote: […] > +static int phy_berlin_sata_probe(struct platform_device *pdev) > +{ > + struct phy *phy; > + struct phy_provider *phy_provider; > + struct priv *priv; > + struct resource *res; > + int i; > + > + priv =

Re: [PATCH v2 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-13 Thread Antoine Ténart
Hello, On Mon, May 12, 2014 at 06:16:46PM +0530, Kishon Vijay Abraham I wrote: > On Monday 12 May 2014 02:46 PM, Antoine Ténart wrote: […] > > +struct phy_desc { > > to be consistent, lets name it phy_berlin_desc. > > + struct phy *phy; > > + u32 val; > > + unsigned

Re: [PATCH v2 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-12 Thread Kishon Vijay Abraham I
Hi, On Monday 12 May 2014 07:48 PM, Sebastian Hesselbarth wrote: > On 05/12/2014 02:46 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Monday 12 May 2014 02:46 PM, Antoine Ténart wrote: >>> The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. >>> >>> Signed-off-by: Antoine Ténar

Re: [PATCH v2 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-12 Thread Sebastian Hesselbarth
On 05/12/2014 02:46 PM, Kishon Vijay Abraham I wrote: Hi, On Monday 12 May 2014 02:46 PM, Antoine Ténart wrote: The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. Signed-off-by: Antoine Ténart --- drivers/phy/Kconfig | 5 ++ drivers/phy/Makefile |

Re: [PATCH v2 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-12 Thread Kishon Vijay Abraham I
Hi, On Monday 12 May 2014 02:46 PM, Antoine Ténart wrote: > The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. > > Signed-off-by: Antoine Ténart > --- > drivers/phy/Kconfig | 5 ++ > drivers/phy/Makefile | 1 + > drivers/phy/phy-berlin-sata.c | 179 > +

[PATCH v2 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-12 Thread Antoine Ténart
The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. Signed-off-by: Antoine Ténart --- drivers/phy/Kconfig | 5 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-berlin-sata.c | 179 ++ 3 files changed, 185 insertions(+