Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On 04/04/2018 10:08 AM, Maxime Ripard wrote: On Tue, Apr 03, 2018 at 07:24:11PM +0300, Sergey Suloev wrote: On 04/03/2018 07:18 PM, Mark Brown wrote: On Tue, Apr 03, 2018 at 07:00:55PM +0300, Sergey Suloev wrote: On 04/03/2018 06:52 PM, Mark Brown wrote: On Tue, Apr 03, 2018 at 06:29:00PM

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On 04/04/2018 10:08 AM, Maxime Ripard wrote: On Tue, Apr 03, 2018 at 07:24:11PM +0300, Sergey Suloev wrote: On 04/03/2018 07:18 PM, Mark Brown wrote: On Tue, Apr 03, 2018 at 07:00:55PM +0300, Sergey Suloev wrote: On 04/03/2018 06:52 PM, Mark Brown wrote: On Tue, Apr 03, 2018 at 06:29:00PM

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On Wed, Apr 04, 2018 at 09:08:18AM +0200, Maxime Ripard wrote: > And I'm pretty sure that papering over an error returned by a driver > is not the right thing to do. We've got specific error handling for timeouts - they get accounted for separately in the stats. It *shouldn't* affect actual

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On Wed, Apr 04, 2018 at 09:08:18AM +0200, Maxime Ripard wrote: > And I'm pretty sure that papering over an error returned by a driver > is not the right thing to do. We've got specific error handling for timeouts - they get accounted for separately in the stats. It *shouldn't* affect actual

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On Tue, Apr 03, 2018 at 07:24:11PM +0300, Sergey Suloev wrote: > On 04/03/2018 07:18 PM, Mark Brown wrote: > > On Tue, Apr 03, 2018 at 07:00:55PM +0300, Sergey Suloev wrote: > > > On 04/03/2018 06:52 PM, Mark Brown wrote: > > > > On Tue, Apr 03, 2018 at 06:29:00PM +0300, Sergey Suloev wrote: > > >

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On Tue, Apr 03, 2018 at 07:24:11PM +0300, Sergey Suloev wrote: > On 04/03/2018 07:18 PM, Mark Brown wrote: > > On Tue, Apr 03, 2018 at 07:00:55PM +0300, Sergey Suloev wrote: > > > On 04/03/2018 06:52 PM, Mark Brown wrote: > > > > On Tue, Apr 03, 2018 at 06:29:00PM +0300, Sergey Suloev wrote: > > >

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On 04/03/2018 07:18 PM, Mark Brown wrote: On Tue, Apr 03, 2018 at 07:00:55PM +0300, Sergey Suloev wrote: On 04/03/2018 06:52 PM, Mark Brown wrote: On Tue, Apr 03, 2018 at 06:29:00PM +0300, Sergey Suloev wrote: As long as sun4i/sun6i SPI drivers have overriden the default "wait for completion"

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On 04/03/2018 07:18 PM, Mark Brown wrote: On Tue, Apr 03, 2018 at 07:00:55PM +0300, Sergey Suloev wrote: On 04/03/2018 06:52 PM, Mark Brown wrote: On Tue, Apr 03, 2018 at 06:29:00PM +0300, Sergey Suloev wrote: As long as sun4i/sun6i SPI drivers have overriden the default "wait for completion"

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On Tue, Apr 03, 2018 at 07:00:55PM +0300, Sergey Suloev wrote: > On 04/03/2018 06:52 PM, Mark Brown wrote: > > On Tue, Apr 03, 2018 at 06:29:00PM +0300, Sergey Suloev wrote: > > > As long as sun4i/sun6i SPI drivers have overriden the default > > > "wait for completion" procedure then we need to

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On Tue, Apr 03, 2018 at 07:00:55PM +0300, Sergey Suloev wrote: > On 04/03/2018 06:52 PM, Mark Brown wrote: > > On Tue, Apr 03, 2018 at 06:29:00PM +0300, Sergey Suloev wrote: > > > As long as sun4i/sun6i SPI drivers have overriden the default > > > "wait for completion" procedure then we need to

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On 04/03/2018 06:52 PM, Mark Brown wrote: On Tue, Apr 03, 2018 at 06:29:00PM +0300, Sergey Suloev wrote: As long as sun4i/sun6i SPI drivers have overriden the default "wait for completion" procedure then we need to properly handle -ETIMEDOUT error from transfer_one(). Why is this connected to

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On 04/03/2018 06:52 PM, Mark Brown wrote: On Tue, Apr 03, 2018 at 06:29:00PM +0300, Sergey Suloev wrote: As long as sun4i/sun6i SPI drivers have overriden the default "wait for completion" procedure then we need to properly handle -ETIMEDOUT error from transfer_one(). Why is this connected to

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On Tue, Apr 03, 2018 at 06:29:00PM +0300, Sergey Suloev wrote: > As long as sun4i/sun6i SPI drivers have overriden the default > "wait for completion" procedure then we need to properly > handle -ETIMEDOUT error from transfer_one(). Why is this connected to those drivers specifically?

Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

On Tue, Apr 03, 2018 at 06:29:00PM +0300, Sergey Suloev wrote: > As long as sun4i/sun6i SPI drivers have overriden the default > "wait for completion" procedure then we need to properly > handle -ETIMEDOUT error from transfer_one(). Why is this connected to those drivers specifically?

[PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

As long as sun4i/sun6i SPI drivers have overriden the default "wait for completion" procedure then we need to properly handle -ETIMEDOUT error from transfer_one(). Signed-off-by: Sergey Suloev --- drivers/spi/spi.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH v2 1/6] spi: core: handle timeout error from transfer_one()

As long as sun4i/sun6i SPI drivers have overriden the default "wait for completion" procedure then we need to properly handle -ETIMEDOUT error from transfer_one(). Signed-off-by: Sergey Suloev --- drivers/spi/spi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git