Re: [PATCH v2 1/7] mhi_bus: core: initial checkin for modem host interface bus driver

2018-08-09 Thread Randy Dunlap
On 07/09/2018 01:08 PM, Sujeev Dias wrote: > This is the initial skeleton driver for mhi bus stack. MHI Host > Interface is a communication protocol to be used by the host to > control and communcate with modem over a high speed peripheral bus. communicate > This module will allow h

Re: [PATCH v2 1/7] mhi_bus: core: initial checkin for modem host interface bus driver

2018-07-11 Thread Rob Herring
On Mon, Jul 09, 2018 at 01:08:08PM -0700, Sujeev Dias wrote: > This is the initial skeleton driver for mhi bus stack. MHI Host > Interface is a communication protocol to be used by the host to > control and communcate with modem over a high speed peripheral bus. > This module will allow host to com

Re: [PATCH v2 1/7] mhi_bus: core: initial checkin for modem host interface bus driver

2018-07-09 Thread Greg Kroah-Hartman
On Mon, Jul 09, 2018 at 01:08:08PM -0700, Sujeev Dias wrote: > +void mhi_driver_unregister(struct mhi_driver *mhi_drv) > +{ > + driver_unregister(&mhi_drv->driver); > +} > +EXPORT_SYMBOL(mhi_driver_unregister); As you are just "wrapping" a core symbol here, please use EXPORT_SYMBOL_GPL(). Act

Re: [PATCH v2 1/7] mhi_bus: core: initial checkin for modem host interface bus driver

2018-07-09 Thread Greg Kroah-Hartman
On Mon, Jul 09, 2018 at 01:08:08PM -0700, Sujeev Dias wrote: > This is the initial skeleton driver for mhi bus stack. MHI Host > Interface is a communication protocol to be used by the host to > control and communcate with modem over a high speed peripheral bus. > This module will allow host to com

Re: [PATCH v2 1/7] mhi_bus: core: initial checkin for modem host interface bus driver

2018-07-09 Thread Greg Kroah-Hartman
On Mon, Jul 09, 2018 at 01:08:08PM -0700, Sujeev Dias wrote: > This is the initial skeleton driver for mhi bus stack. MHI Host > Interface is a communication protocol to be used by the host to > control and communcate with modem over a high speed peripheral bus. > This module will allow host to com

[PATCH v2 1/7] mhi_bus: core: initial checkin for modem host interface bus driver

2018-07-09 Thread Sujeev Dias
This is the initial skeleton driver for mhi bus stack. MHI Host Interface is a communication protocol to be used by the host to control and communcate with modem over a high speed peripheral bus. This module will allow host to communicate with external devices that support MHI protocol. Signed-off