Re: [PATCH v2 1/8] leds: Add support for AXP20X CHGLED

2019-02-18 Thread Stefan Mavrodiev
On 2/15/19 8:32 PM, Pavel Machek wrote: Hi! On Fri, Feb 15, 2019 at 01:50:06PM +0200, Stefan Mavrodiev wrote: +static ssize_t control_store(struct device *dev, struct device_attribute *attr, +const char *buf, size_t size) +{ + struct led_classdev *cdev = dev

Re: [PATCH v2 1/8] leds: Add support for AXP20X CHGLED

2019-02-15 Thread Pavel Machek
Hi! > On Fri, Feb 15, 2019 at 01:50:06PM +0200, Stefan Mavrodiev wrote: > > +static ssize_t control_store(struct device *dev, struct device_attribute > > *attr, > > +const char *buf, size_t size) > > +{ > > + struct led_classdev *cdev = dev_get_drvdata(dev); > > + str

Re: [PATCH v2 1/8] leds: Add support for AXP20X CHGLED

2019-02-15 Thread Maxime Ripard
Hi Stefan, Thanks for working on this. On Fri, Feb 15, 2019 at 01:50:06PM +0200, Stefan Mavrodiev wrote: > +static ssize_t control_show(struct device *dev, struct device_attribute > *attr, > + char *buf) > +{ > + struct led_classdev *cdev = dev_get_drvdata(dev); > +

Re: [PATCH v2 1/8] leds: Add support for AXP20X CHGLED

2019-02-15 Thread Stefan Mavrodiev
On 2/15/19 1:50 PM, Stefan Mavrodiev wrote: Most of AXP20x PMIC chips have built-in battery charger with LED indicator. The LED can be controlled ether by the charger or manually by a register. The default is (except for AXP209) manual control, which makes this LED useless, since there is no d

[PATCH v2 1/8] leds: Add support for AXP20X CHGLED

2019-02-15 Thread Stefan Mavrodiev
Most of AXP20x PMIC chips have built-in battery charger with LED indicator. The LED can be controlled ether by the charger or manually by a register. The default is (except for AXP209) manual control, which makes this LED useless, since there is no device driver. The driver rely on AXP20X MFD dri