Re: [PATCH v2 1/9] perf tools: add parse events append error

2019-10-23 Thread Jiri Olsa
On Tue, Oct 22, 2019 at 05:53:29PM -0700, Ian Rogers wrote: > Parse event error handling may overwrite one error string with another > creating memory leaks and masking errors. Introduce a helper routine > that appends error messages and avoids the memory leak. good idea, it became little messy wi

[PATCH v2 1/9] perf tools: add parse events append error

2019-10-22 Thread Ian Rogers
Parse event error handling may overwrite one error string with another creating memory leaks and masking errors. Introduce a helper routine that appends error messages and avoids the memory leak. Signed-off-by: Ian Rogers --- tools/perf/util/parse-events.c | 102 ++---