Re: [PATCH v2 10/10] ARM: mstar: SMP support

2020-12-02 Thread Daniel Palmer
Hi Russell, On Wed, 2 Dec 2020 at 00:04, Russell King - ARM Linux admin wrote: > > On Tue, Dec 01, 2020 at 10:43:30PM +0900, Daniel Palmer wrote: > > + np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl"); > > + smpctrl = of_iomap(np, 0); > > + > > + if (!smpctrl) > > +

Re: [PATCH v2 10/10] ARM: mstar: SMP support

2020-12-01 Thread Russell King - ARM Linux admin
On Tue, Dec 01, 2020 at 10:43:30PM +0900, Daniel Palmer wrote: > + np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl"); > + smpctrl = of_iomap(np, 0); > + > + if (!smpctrl) > + return -ENODEV; Wouldn't -ENOMEM be more appropriate here? -- RMK's Patch system:

[PATCH v2 10/10] ARM: mstar: SMP support

2020-12-01 Thread Daniel Palmer
This patch adds SMP support for MStar/Sigmastar chips that have a second core like those in the infinity2m family. So far only single and dual core chips have been found so this does the bare minimum to boot the second core. From what I can tell not having the "holding pen" code to handle