Re: [PATCH v2 10/10] intel-gtt: Read 64bit for gmar_bus_addr

2013-12-23 Thread Bjorn Helgaas
On Sat, Dec 21, 2013 at 11:50 AM, Bjorn Helgaas wrote: > [+cc Daniel] > > On Fri, Dec 20, 2013 at 05:19:38PM -0800, Yinghai Lu wrote: >> On Fri, Dec 20, 2013 at 4:27 PM, Bjorn Helgaas wrote: >> >> > Why are we reading these BARs directly anyway? These look like >> > standard PCI BARs (I810_GMADD

Re: [PATCH v2 10/10] intel-gtt: Read 64bit for gmar_bus_addr

2013-12-21 Thread Bjorn Helgaas
[+cc Daniel] On Fri, Dec 20, 2013 at 05:19:38PM -0800, Yinghai Lu wrote: > On Fri, Dec 20, 2013 at 4:27 PM, Bjorn Helgaas wrote: > > > Why are we reading these BARs directly anyway? These look like > > standard PCI BARs (I810_GMADDR == 0x10 and I915_GMADDR == 0x18), so > > the PCI core should a

Re: [PATCH v2 10/10] intel-gtt: Read 64bit for gmar_bus_addr

2013-12-20 Thread Yinghai Lu
On Fri, Dec 20, 2013 at 4:27 PM, Bjorn Helgaas wrote: > Why are we reading these BARs directly anyway? These look like > standard PCI BARs (I810_GMADDR == 0x10 and I915_GMADDR == 0x18), so > the PCI core should already be reading them correctly, shouldn't it? > Can't we just use pcibios_resource

Re: [PATCH v2 10/10] intel-gtt: Read 64bit for gmar_bus_addr

2013-12-20 Thread Bjorn Helgaas
On Mon, Nov 25, 2013 at 6:28 PM, Yinghai Lu wrote: > That bar could be 64bit pref mem and above 4G. > > -v2: refresh to 3.13-rc1 > > Signed-off-by: Yinghai Lu > Cc: David Airlie > Reviewed-by: Daniel Vetter > --- > drivers/char/agp/intel-gtt.c | 14 ++ > 1 file changed, 10 insertio

Re: [PATCH v2 10/10] intel-gtt: Read 64bit for gmar_bus_addr

2013-12-11 Thread Yinghai Lu
On Wed, Dec 11, 2013 at 10:48 AM, Bjorn Helgaas wrote: > > Doesn't that mean that this series should be reordered so this patch > is *before* patches 5-9 to avoid bisection breakage? I know you've > split up and reposted parts of the series, but the question still > applies. Yes, you are right.

Re: [PATCH v2 10/10] intel-gtt: Read 64bit for gmar_bus_addr

2013-12-11 Thread Bjorn Helgaas
On Tue, Nov 26, 2013 at 12:35 PM, Yinghai Lu wrote: > On Mon, Nov 25, 2013 at 7:46 PM, Bjorn Helgaas wrote: >> On Mon, Nov 25, 2013 at 6:28 PM, Yinghai Lu wrote: >>> That bar could be 64bit pref mem and above 4G. >>> >>> -v2: refresh to 3.13-rc1 >>> >>> Signed-off-by: Yinghai Lu >>> Cc: David A

Re: [PATCH v2 10/10] intel-gtt: Read 64bit for gmar_bus_addr

2013-11-26 Thread Yinghai Lu
On Mon, Nov 25, 2013 at 7:46 PM, Bjorn Helgaas wrote: > On Mon, Nov 25, 2013 at 6:28 PM, Yinghai Lu wrote: >> That bar could be 64bit pref mem and above 4G. >> >> -v2: refresh to 3.13-rc1 >> >> Signed-off-by: Yinghai Lu >> Cc: David Airlie >> Reviewed-by: Daniel Vetter > > This looks OK to me.

Re: [PATCH v2 10/10] intel-gtt: Read 64bit for gmar_bus_addr

2013-11-25 Thread Bjorn Helgaas
On Mon, Nov 25, 2013 at 6:28 PM, Yinghai Lu wrote: > That bar could be 64bit pref mem and above 4G. > > -v2: refresh to 3.13-rc1 > > Signed-off-by: Yinghai Lu > Cc: David Airlie > Reviewed-by: Daniel Vetter This looks OK to me. Does it depend on any previous patches in this series? If not, I

[PATCH v2 10/10] intel-gtt: Read 64bit for gmar_bus_addr

2013-11-25 Thread Yinghai Lu
That bar could be 64bit pref mem and above 4G. -v2: refresh to 3.13-rc1 Signed-off-by: Yinghai Lu Cc: David Airlie Reviewed-by: Daniel Vetter --- drivers/char/agp/intel-gtt.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/char/agp/intel-gtt.c b/dri