Re: [PATCH v2 10/12] sched/core: uclamp: use TG's clamps to restrict Task's clamps

2018-07-26 Thread Suren Baghdasaryan
Sorry for the delay. Overlooked this comment... On Tue, Jul 24, 2018 at 8:49 AM, Patrick Bellasi wrote: > On 24-Jul 08:28, Suren Baghdasaryan wrote: > > Hi Patrick. Thanks for the explanation and links. No more questions > > from me on this one :) > > No problems at all! > > The important questi

Re: [PATCH v2 10/12] sched/core: uclamp: use TG's clamps to restrict Task's clamps

2018-07-24 Thread Patrick Bellasi
On 24-Jul 08:28, Suren Baghdasaryan wrote: > Hi Patrick. Thanks for the explanation and links. No more questions > from me on this one :) No problems at all! The important question is instead: does it makes sense for you too? I think the important bits are that we are all on the same page about

Re: [PATCH v2 10/12] sched/core: uclamp: use TG's clamps to restrict Task's clamps

2018-07-24 Thread Suren Baghdasaryan
Hi Patrick. Thanks for the explanation and links. No more questions from me on this one :) On Tue, Jul 24, 2018 at 2:56 AM, Patrick Bellasi wrote: > On 23-Jul 10:11, Suren Baghdasaryan wrote: >> On Mon, Jul 23, 2018 at 8:40 AM, Patrick Bellasi >> wrote: >> > On 21-Jul 20:05, Suren Baghdasaryan w

Re: [PATCH v2 10/12] sched/core: uclamp: use TG's clamps to restrict Task's clamps

2018-07-24 Thread Patrick Bellasi
On 23-Jul 10:11, Suren Baghdasaryan wrote: > On Mon, Jul 23, 2018 at 8:40 AM, Patrick Bellasi > wrote: > > On 21-Jul 20:05, Suren Baghdasaryan wrote: > >> On Mon, Jul 16, 2018 at 1:29 AM, Patrick Bellasi [...] > >> So to satisfy both TG and syscall requirements I think you would > >> need to cho

Re: [PATCH v2 10/12] sched/core: uclamp: use TG's clamps to restrict Task's clamps

2018-07-23 Thread Suren Baghdasaryan
On Mon, Jul 23, 2018 at 8:40 AM, Patrick Bellasi wrote: > On 21-Jul 20:05, Suren Baghdasaryan wrote: >> On Mon, Jul 16, 2018 at 1:29 AM, Patrick Bellasi >> wrote: >> > When a task's util_clamp value is configured via sched_setattr(2), this >> > value has to be properly accounted in the correspond

Re: [PATCH v2 10/12] sched/core: uclamp: use TG's clamps to restrict Task's clamps

2018-07-23 Thread Patrick Bellasi
On 21-Jul 20:05, Suren Baghdasaryan wrote: > On Mon, Jul 16, 2018 at 1:29 AM, Patrick Bellasi > wrote: > > When a task's util_clamp value is configured via sched_setattr(2), this > > value has to be properly accounted in the corresponding clamp group > > every time the task is enqueued and dequeue

Re: [PATCH v2 10/12] sched/core: uclamp: use TG's clamps to restrict Task's clamps

2018-07-21 Thread Suren Baghdasaryan
On Mon, Jul 16, 2018 at 1:29 AM, Patrick Bellasi wrote: > When a task's util_clamp value is configured via sched_setattr(2), this > value has to be properly accounted in the corresponding clamp group > every time the task is enqueued and dequeued. When cgroups are also in > use, per-task clamp val

[PATCH v2 10/12] sched/core: uclamp: use TG's clamps to restrict Task's clamps

2018-07-16 Thread Patrick Bellasi
When a task's util_clamp value is configured via sched_setattr(2), this value has to be properly accounted in the corresponding clamp group every time the task is enqueued and dequeued. When cgroups are also in use, per-task clamp values have to be aggregated to those of the CPU's controller's Task