Re: [PATCH v2 10/23] firmware: add helper to copy built-in data to pre-alloc buffer

2017-11-30 Thread Luis R. Rodriguez
On Wed, Nov 29, 2017 at 11:17:15AM +0100, Greg KH wrote: > On Mon, Nov 20, 2017 at 10:23:56AM -0800, Luis R. Rodriguez wrote: > > This makes it clearer that the parameters passed are only used for > > the preallocated buffer option, ie, when a caller uses: > > > > request_firmware_into_buf() >

Re: [PATCH v2 10/23] firmware: add helper to copy built-in data to pre-alloc buffer

2017-11-29 Thread Greg KH
On Mon, Nov 20, 2017 at 10:23:56AM -0800, Luis R. Rodriguez wrote: > This makes it clearer that the parameters passed are only used for > the preallocated buffer option, ie, when a caller uses: > > request_firmware_into_buf() > > Otherwise this code won't run. We flip the logic just so the

[PATCH v2 10/23] firmware: add helper to copy built-in data to pre-alloc buffer

2017-11-20 Thread Luis R. Rodriguez
This makes it clearer that the parameters passed are only used for the preallocated buffer option, ie, when a caller uses: request_firmware_into_buf() Otherwise this code won't run. We flip the logic just so the actual prellocated buf code is not indented. Signed-off-by: Luis R. Rodrigue