Re: [PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-26 Thread Philipp Zabel
On Tue, 2020-08-25 at 21:30 +0300, Abel Vesa wrote: [...] > > if (assert) > > pm_runtime_get_sync(); > > spin_lock_irqsave(); > > /* ... */ > > spin_unlock_irqrestore(); > > if (assert && asserted_before) > > pm_runtime_put(); > > > > On a second

Re: [PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-25 Thread Abel Vesa
On 20-08-25 14:07:29, Philipp Zabel wrote: > On Tue, 2020-08-25 at 14:24 +0300, Abel Vesa wrote: > [...] > > > > +static int imx_blk_ctrl_reset_set(struct reset_controller_dev *rcdev, > > > > + unsigned long id, bool assert) > > > > +{ > > > > + struct

Re: [PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-25 Thread Abel Vesa
On 20-08-25 14:07:29, Philipp Zabel wrote: > On Tue, 2020-08-25 at 14:24 +0300, Abel Vesa wrote: > [...] > > > > +static int imx_blk_ctrl_reset_set(struct reset_controller_dev *rcdev, > > > > + unsigned long id, bool assert) > > > > +{ > > > > + struct

Re: [PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-25 Thread Philipp Zabel
On Tue, 2020-08-25 at 14:24 +0300, Abel Vesa wrote: [...] > > > +static int imx_blk_ctrl_reset_set(struct reset_controller_dev *rcdev, > > > + unsigned long id, bool assert) > > > +{ > > > + struct imx_blk_ctrl_drvdata *drvdata = container_of(rcdev, > > > +

Re: [PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-25 Thread Abel Vesa
On 20-08-25 12:48:41, Philipp Zabel wrote: > On Fri, 2020-08-14 at 15:09 +0300, Abel Vesa wrote: > > On i.MX8MP, there is a new type of IP which is called BLK_CTRL in > > RM and usually is comprised of some GPRs that are considered too > > generic to be part of any dedicated IP from that specific

Re: [PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-25 Thread Philipp Zabel
On Fri, 2020-08-14 at 15:09 +0300, Abel Vesa wrote: > On i.MX8MP, there is a new type of IP which is called BLK_CTRL in > RM and usually is comprised of some GPRs that are considered too > generic to be part of any dedicated IP from that specific subsystem. > > In general, some of the GPRs have

Re: [PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-19 Thread Dong Aisheng
On Thu, Aug 20, 2020 at 4:31 AM Abel Vesa wrote: > > > +extern const struct imx_blk_ctrl_dev_data imx8mp_audio_blk_ctrl_dev_data > > > __initconst; > > > +extern const struct imx_blk_ctrl_dev_data imx8mp_media_blk_ctrl_dev_data > > > __initconst; > > > +extern const struct

Re: [PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-19 Thread Abel Vesa
On 20-08-18 19:27:03, Dong Aisheng wrote: > On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa wrote: > > > > On i.MX8MP, there is a new type of IP which is called BLK_CTRL in > > RM and usually is comprised of some GPRs that are considered too > > generic to be part of any dedicated IP from that specific

Re: [PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-18 Thread Dong Aisheng
On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa wrote: > > On i.MX8MP, there is a new type of IP which is called BLK_CTRL in > RM and usually is comprised of some GPRs that are considered too > generic to be part of any dedicated IP from that specific subsystem. > > In general, some of the GPRs have

[PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-14 Thread Abel Vesa
On i.MX8MP, there is a new type of IP which is called BLK_CTRL in RM and usually is comprised of some GPRs that are considered too generic to be part of any dedicated IP from that specific subsystem. In general, some of the GPRs have some clock bits, some have reset bits, so in order to be able