Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-21 Thread Sakari Ailus
On Mon, Dec 21, 2020 at 10:52:52AM +, Daniel Scally wrote: > > On 21/12/2020 10:21, Sakari Ailus wrote: > > Hi Daniel, Andy, > > > > On Sat, Dec 19, 2020 at 11:48:51PM +, Daniel Scally wrote: > >> On 19/12/2020 18:52, Andy Shevchenko wrote: > >>> On Sat, Dec 19, 2020 at 2:25 AM Daniel

Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-21 Thread Daniel Scally
On 21/12/2020 10:21, Sakari Ailus wrote: > Hi Daniel, Andy, > > On Sat, Dec 19, 2020 at 11:48:51PM +, Daniel Scally wrote: >> On 19/12/2020 18:52, Andy Shevchenko wrote: >>> On Sat, Dec 19, 2020 at 2:25 AM Daniel Scally wrote: On 18/12/2020 21:17, Andy Shevchenko wrote: > On Thu,

Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-21 Thread Sakari Ailus
Hi Daniel, Andy, On Sat, Dec 19, 2020 at 11:48:51PM +, Daniel Scally wrote: > On 19/12/2020 18:52, Andy Shevchenko wrote: > > On Sat, Dec 19, 2020 at 2:25 AM Daniel Scally wrote: > >> On 18/12/2020 21:17, Andy Shevchenko wrote: > >>> On Thu, Dec 17, 2020 at 11:43:37PM +, Daniel Scally

Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-19 Thread Daniel Scally
On 19/12/2020 18:52, Andy Shevchenko wrote: > On Sat, Dec 19, 2020 at 2:25 AM Daniel Scally wrote: >> On 18/12/2020 21:17, Andy Shevchenko wrote: >>> On Thu, Dec 17, 2020 at 11:43:37PM +, Daniel Scally wrote: > > ... > +sensor->ep_properties[0] =

Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-19 Thread Daniel Scally
On 19/12/2020 00:39, Laurent Pinchart wrote: > Hi Daniel, > > On Fri, Dec 18, 2020 at 11:57:54PM +, Daniel Scally wrote: >> Hi Laurent - thanks for the comments >> >> On 18/12/2020 16:53, Laurent Pinchart wrote: +static void cio2_bridge_init_property_names(struct cio2_sensor *sensor)

Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-19 Thread Andy Shevchenko
On Sat, Dec 19, 2020 at 2:25 AM Daniel Scally wrote: > On 18/12/2020 21:17, Andy Shevchenko wrote: > > On Thu, Dec 17, 2020 at 11:43:37PM +, Daniel Scally wrote: ... > >> +sensor->ep_properties[0] = > >> PROPERTY_ENTRY_U32(sensor->prop_names.bus_type, 4); > > > > Does 4 has any meaning

Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-18 Thread Laurent Pinchart
Hi Daniel, On Fri, Dec 18, 2020 at 11:57:54PM +, Daniel Scally wrote: > Hi Laurent - thanks for the comments > > On 18/12/2020 16:53, Laurent Pinchart wrote: > >> +static void cio2_bridge_init_property_names(struct cio2_sensor *sensor) > >> +{ > >> +

Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-18 Thread Daniel Scally
Hi Andy, thanks for the comments On 18/12/2020 21:17, Andy Shevchenko wrote: > On Thu, Dec 17, 2020 at 11:43:37PM +, Daniel Scally wrote: >> Currently on platforms designed for Windows, connections between CIO2 and >> sensors are not properly defined in DSDT. This patch extends the ipu3-cio2

Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-18 Thread Daniel Scally
Hi Laurent - thanks for the comments On 18/12/2020 16:53, Laurent Pinchart wrote: >> +static void cio2_bridge_init_property_names(struct cio2_sensor *sensor) >> +{ >> +strscpy(sensor->prop_names.clock_frequency, "clock-frequency", >> +sizeof(sensor->prop_names.clock_frequency));

Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-18 Thread Andy Shevchenko
On Thu, Dec 17, 2020 at 11:43:37PM +, Daniel Scally wrote: > Currently on platforms designed for Windows, connections between CIO2 and > sensors are not properly defined in DSDT. This patch extends the ipu3-cio2 > driver to compensate by building software_node connections, parsing the >

Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-18 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Thu, Dec 17, 2020 at 11:43:37PM +, Daniel Scally wrote: > Currently on platforms designed for Windows, connections between CIO2 and > sensors are not properly defined in DSDT. This patch extends the ipu3-cio2 > driver to compensate by building

[PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2020-12-17 Thread Daniel Scally
Currently on platforms designed for Windows, connections between CIO2 and sensors are not properly defined in DSDT. This patch extends the ipu3-cio2 driver to compensate by building software_node connections, parsing the connection properties from the sensor's SSDB buffer. Suggested-by: Jordan