Re: [PATCH v2 13/14] ARM: STi: DT: STiH410: Add usb2 picophy dt nodes

2014-11-14 Thread Arnd Bergmann
On Friday 14 November 2014 13:34:25 Peter Griffin wrote: > > > > > From looking around in the source I see a few different ways people have > > > done this: - > > > > > > 1) Some drivers encode the data statically into the source and make a > > > decision based on compatible string. > > > 2) So

Re: [PATCH v2 13/14] ARM: STi: DT: STiH410: Add usb2 picophy dt nodes

2014-11-14 Thread Peter Griffin
Hi Arnd, Thanks for taking the time to explain this. On Fri, 14 Nov 2014, Arnd Bergmann wrote: > > address of the device's resources within the address space defined by its > > parent bus"). > > You will also have to add an appropriate 'ranges' property then. > > > Or maybe you meant, if I wa

Re: [PATCH v2 13/14] ARM: STi: DT: STiH410: Add usb2 picophy dt nodes

2014-11-14 Thread Arnd Bergmann
On Friday 14 November 2014 09:56:21 Peter Griffin wrote: > > I'll appologize in advance as I'm not sure I've understood you correctly, > definately your answer > has given me a bunch more questions to clarify my understanding... > > In the case of this particular node, then both reg properties r

Re: [PATCH v2 13/14] ARM: STi: DT: STiH410: Add usb2 picophy dt nodes

2014-11-14 Thread Peter Griffin
Hi Arnd, On Thu, 13 Nov 2014, Arnd Bergmann wrote: > On Thursday 13 November 2014 14:54:19 Peter Griffin wrote: > > > > > > > > It also seems that you have put the node in the wrong place, as the reg > > > property apparently refers to a different address space. Did you mean > > > to put this u

Re: [PATCH v2 13/14] ARM: STi: DT: STiH410: Add usb2 picophy dt nodes

2014-11-13 Thread Arnd Bergmann
On Thursday 13 November 2014 14:54:19 Peter Griffin wrote: > > > > > It also seems that you have put the node in the wrong place, as the reg > > property apparently refers to a different address space. Did you mean > > to put this under the syscfg_core node? > > Your correct in that it refers to

Re: [PATCH v2 13/14] ARM: STi: DT: STiH410: Add usb2 picophy dt nodes

2014-11-13 Thread Peter Griffin
Hi Arnd, Thanks for reviewing. On Thu, 13 Nov 2014, Arnd Bergmann wrote: > On Thursday 13 November 2014 11:00:16 Peter Griffin wrote: > > + soc { > > + usb2_picophy0: usbpicophy@0 { > > + compatible = "st,stih407-usb2-phy"; > > + re

Re: [PATCH v2 13/14] ARM: STi: DT: STiH410: Add usb2 picophy dt nodes

2014-11-13 Thread Arnd Bergmann
On Thursday 13 November 2014 11:00:16 Peter Griffin wrote: > + soc { > + usb2_picophy0: usbpicophy@0 { > + compatible = "st,stih407-usb2-phy"; > + reg = <0xf8 0x04>, /* syscfg 5062 */ > + <0xf4 0x04>;

[PATCH v2 13/14] ARM: STi: DT: STiH410: Add usb2 picophy dt nodes

2014-11-13 Thread Peter Griffin
This patch adds the dt nodes for the extra usb2 picophys found on the stih410. These two picophys are used in conjunction with the extra ehci/ohci usb controllers also found on the stih410. Signed-off-by: Peter Griffin --- arch/arm/boot/dts/stih410.dtsi | 24 1 file chan