Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-11 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 10, 2015 at 03:35:24PM -0600, Josh Poimboeuf escreveu: > On Thu, Dec 10, 2015 at 08:54:45AM -0600, Josh Poimboeuf wrote: > > On Thu, Dec 10, 2015 at 10:40:39AM +0900, Namhyung Kim wrote: > > > > - usage.c: used in several places for die() and error(), but these are > > > > trivial fun

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-10 Thread Josh Poimboeuf
On Thu, Dec 10, 2015 at 08:54:45AM -0600, Josh Poimboeuf wrote: > On Thu, Dec 10, 2015 at 10:40:39AM +0900, Namhyung Kim wrote: > > > - usage.c: used in several places for die() and error(), but these are > > > trivial functions which can be duplicated. > > > > Not sure it's ok to call die() or

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-10 Thread Josh Poimboeuf
On Thu, Dec 10, 2015 at 09:55:53AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 09, 2015 at 12:59:15PM -0600, Josh Poimboeuf escreveu: > > On Wed, Dec 09, 2015 at 12:58:08PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Dec 09, 2015 at 06:33:15AM -0600, Josh Poimboeuf escreveu: > > >

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-10 Thread Josh Poimboeuf
On Thu, Dec 10, 2015 at 10:40:39AM +0900, Namhyung Kim wrote: > Hi Josh, > > On Wed, Dec 09, 2015 at 12:59:15PM -0600, Josh Poimboeuf wrote: > > On Wed, Dec 09, 2015 at 12:58:08PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Dec 09, 2015 at 06:33:15AM -0600, Josh Poimboeuf escreveu: > > >

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-10 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 09, 2015 at 12:59:15PM -0600, Josh Poimboeuf escreveu: > On Wed, Dec 09, 2015 at 12:58:08PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Dec 09, 2015 at 06:33:15AM -0600, Josh Poimboeuf escreveu: > > > On Wed, Dec 09, 2015 at 09:03:43AM +0100, Ingo Molnar wrote: > > > > > > > > *

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-09 Thread Namhyung Kim
On Mon, Dec 07, 2015 at 10:21:52PM -0600, Josh Poimboeuf wrote: > The perf subcommand framework is needed for other tools. Move > parse-options.c and its dependencies over to libapi. > > Any function names with 'perf' have been renamed to something more > generic. > > Also created a util_cfg str

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-09 Thread Namhyung Kim
Hi Josh, On Wed, Dec 09, 2015 at 12:59:15PM -0600, Josh Poimboeuf wrote: > On Wed, Dec 09, 2015 at 12:58:08PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Dec 09, 2015 at 06:33:15AM -0600, Josh Poimboeuf escreveu: > > > On Wed, Dec 09, 2015 at 09:03:43AM +0100, Ingo Molnar wrote: > > > > >

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-09 Thread Josh Poimboeuf
On Wed, Dec 09, 2015 at 12:58:08PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 09, 2015 at 06:33:15AM -0600, Josh Poimboeuf escreveu: > > On Wed, Dec 09, 2015 at 09:03:43AM +0100, Ingo Molnar wrote: > > > > > > * Josh Poimboeuf wrote: > > > > > > > > > wouldn't necessarily be a clean sp

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-09 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 09, 2015 at 06:33:15AM -0600, Josh Poimboeuf escreveu: > On Wed, Dec 09, 2015 at 09:03:43AM +0100, Ingo Molnar wrote: > > > > * Josh Poimboeuf wrote: > > > > > > > wouldn't necessarily be a clean split. It would also possibly create > > > > > more > > > > > room for error for the

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-09 Thread Josh Poimboeuf
On Wed, Dec 09, 2015 at 09:03:43AM +0100, Ingo Molnar wrote: > > * Josh Poimboeuf wrote: > > > > > wouldn't necessarily be a clean split. It would also possibly create > > > > more > > > > room for error for the users of libapi, since there would then be three > > > > config interfaces inste

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-09 Thread Ingo Molnar
* Josh Poimboeuf wrote: > > > wouldn't necessarily be a clean split. It would also possibly create > > > more > > > room for error for the users of libapi, since there would then be three > > > config interfaces instead of one. > > > > Humm, and now that you talk... libapi was supposed to b

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-08 Thread Josh Poimboeuf
On Tue, Dec 08, 2015 at 07:27:32PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 08, 2015 at 03:48:25PM -0600, Josh Poimboeuf escreveu: > > On Tue, Dec 08, 2015 at 04:40:26PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Dec 08, 2015 at 01:17:00PM -0600, Josh Poimboeuf escreveu: > > >

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-08 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 08, 2015 at 03:48:25PM -0600, Josh Poimboeuf escreveu: > On Tue, Dec 08, 2015 at 04:40:26PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Dec 08, 2015 at 01:17:00PM -0600, Josh Poimboeuf escreveu: > > > On Tue, Dec 08, 2015 at 04:09:31PM -0300, Arnaldo Carvalho de Melo wrote: > > >

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-08 Thread Josh Poimboeuf
On Tue, Dec 08, 2015 at 04:40:26PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 08, 2015 at 01:17:00PM -0600, Josh Poimboeuf escreveu: > > On Tue, Dec 08, 2015 at 04:09:31PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Dec 08, 2015 at 12:49:53PM -0600, Josh Poimboeuf escreveu: > > >

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-08 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 08, 2015 at 01:17:00PM -0600, Josh Poimboeuf escreveu: > On Tue, Dec 08, 2015 at 04:09:31PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Dec 08, 2015 at 12:49:53PM -0600, Josh Poimboeuf escreveu: > > > On Tue, Dec 08, 2015 at 07:16:26PM +0100, Jiri Olsa wrote: > > > > On Mon, Dec

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-08 Thread Josh Poimboeuf
On Tue, Dec 08, 2015 at 04:09:31PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 08, 2015 at 12:49:53PM -0600, Josh Poimboeuf escreveu: > > On Tue, Dec 08, 2015 at 07:16:26PM +0100, Jiri Olsa wrote: > > > On Mon, Dec 07, 2015 at 10:21:52PM -0600, Josh Poimboeuf wrote: > > > > The perf subcom

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-08 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 08, 2015 at 12:49:53PM -0600, Josh Poimboeuf escreveu: > On Tue, Dec 08, 2015 at 07:16:26PM +0100, Jiri Olsa wrote: > > On Mon, Dec 07, 2015 at 10:21:52PM -0600, Josh Poimboeuf wrote: > > > The perf subcommand framework is needed for other tools. Move > > > parse-options.c and its depe

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-08 Thread Josh Poimboeuf
On Tue, Dec 08, 2015 at 07:16:26PM +0100, Jiri Olsa wrote: > On Mon, Dec 07, 2015 at 10:21:52PM -0600, Josh Poimboeuf wrote: > > The perf subcommand framework is needed for other tools. Move > > parse-options.c and its dependencies over to libapi. > > > > Any function names with 'perf' have been

Re: [PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-08 Thread Jiri Olsa
On Mon, Dec 07, 2015 at 10:21:52PM -0600, Josh Poimboeuf wrote: > The perf subcommand framework is needed for other tools. Move > parse-options.c and its dependencies over to libapi. > > Any function names with 'perf' have been renamed to something more > generic. > > Also created a util_cfg str

[PATCH v2 14/14] perf tools: Move subcommand framework and related utils to libapi

2015-12-07 Thread Josh Poimboeuf
The perf subcommand framework is needed for other tools. Move parse-options.c and its dependencies over to libapi. Any function names with 'perf' have been renamed to something more generic. Also created a util_cfg struct for passing perf-specific configuration to the library. Specifying the co