Re: [PATCH v2 14/15] clk: sunxi-ng: Add H3 clocks

2016-06-28 Thread Maxime Ripard
On Mon, Jun 27, 2016 at 05:53:37PM -0700, Michael Turquette wrote: > > > The nice thing about struct ccu_common is that you don't have to walk > > > the list of clocks for each separate clock type like the above probe > > > function does. I'm still thinking of the best way to solve this > > >

Re: [PATCH v2 14/15] clk: sunxi-ng: Add H3 clocks

2016-06-28 Thread Maxime Ripard
On Mon, Jun 27, 2016 at 05:53:37PM -0700, Michael Turquette wrote: > > > The nice thing about struct ccu_common is that you don't have to walk > > > the list of clocks for each separate clock type like the above probe > > > function does. I'm still thinking of the best way to solve this > > >

Re: [PATCH v2 14/15] clk: sunxi-ng: Add H3 clocks

2016-06-26 Thread Maxime Ripard
Hi Mike, On Fri, Jun 24, 2016 at 05:28:37PM -0700, Michael Turquette wrote: > Hi Maxime, > > Nice series! Looks really great to me. :-) Great :) > Quoting Maxime Ripard (2016-06-07 13:41:53) > > +static SUNXI_CCU_NKMP_WITH_GATE_LOCK(pll_cpux_clk, "pll-cpux", > > +

Re: [PATCH v2 14/15] clk: sunxi-ng: Add H3 clocks

2016-06-26 Thread Maxime Ripard
Hi Mike, On Fri, Jun 24, 2016 at 05:28:37PM -0700, Michael Turquette wrote: > Hi Maxime, > > Nice series! Looks really great to me. :-) Great :) > Quoting Maxime Ripard (2016-06-07 13:41:53) > > +static SUNXI_CCU_NKMP_WITH_GATE_LOCK(pll_cpux_clk, "pll-cpux", > > +

Re: [PATCH v2 14/15] clk: sunxi-ng: Add H3 clocks

2016-06-24 Thread Michael Turquette
Hi Maxime, Nice series! Looks really great to me. :-) Quoting Maxime Ripard (2016-06-07 13:41:53) > +static SUNXI_CCU_NKMP_WITH_GATE_LOCK(pll_cpux_clk, "pll-cpux", > +"osc24M", 0x000, > +8, 5, /* N */ > +

Re: [PATCH v2 14/15] clk: sunxi-ng: Add H3 clocks

2016-06-24 Thread Michael Turquette
Hi Maxime, Nice series! Looks really great to me. :-) Quoting Maxime Ripard (2016-06-07 13:41:53) > +static SUNXI_CCU_NKMP_WITH_GATE_LOCK(pll_cpux_clk, "pll-cpux", > +"osc24M", 0x000, > +8, 5, /* N */ > +

Re: [PATCH v2 14/15] clk: sunxi-ng: Add H3 clocks

2016-06-09 Thread Jean-Francois Moine
On Tue, 7 Jun 2016 22:41:53 +0200 Maxime Ripard wrote: > Add the list of clocks and resets found in the H3 CCU. > > Signed-off-by: Maxime Ripard > > --- > Changes from v1: > - Only build the H3 clocks description when

Re: [PATCH v2 14/15] clk: sunxi-ng: Add H3 clocks

2016-06-09 Thread Jean-Francois Moine
On Tue, 7 Jun 2016 22:41:53 +0200 Maxime Ripard wrote: > Add the list of clocks and resets found in the H3 CCU. > > Signed-off-by: Maxime Ripard > > --- > Changes from v1: > - Only build the H3 clocks description when MACH_SUN8I is set > --- > drivers/clk/sunxi-ng/Makefile| 2 +

[PATCH v2 14/15] clk: sunxi-ng: Add H3 clocks

2016-06-07 Thread Maxime Ripard
Add the list of clocks and resets found in the H3 CCU. Signed-off-by: Maxime Ripard --- Changes from v1: - Only build the H3 clocks description when MACH_SUN8I is set --- drivers/clk/sunxi-ng/Makefile| 2 + drivers/clk/sunxi-ng/ccu-sun8i-h3.c |

[PATCH v2 14/15] clk: sunxi-ng: Add H3 clocks

2016-06-07 Thread Maxime Ripard
Add the list of clocks and resets found in the H3 CCU. Signed-off-by: Maxime Ripard --- Changes from v1: - Only build the H3 clocks description when MACH_SUN8I is set --- drivers/clk/sunxi-ng/Makefile| 2 + drivers/clk/sunxi-ng/ccu-sun8i-h3.c | 703