Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
On 01/04/16 at 01:26pm, Borislav Petkov wrote: > On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote: > > Replied to Toshi old kernel will export the "GART" region for amd cards. > > So for old kernel and new kexec-tools we will have problem. > > > > I think add the GART desc for

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Toshi Kani
On Mon, 2016-01-04 at 20:41 +0100, Borislav Petkov wrote: > On Mon, Jan 04, 2016 at 10:57:40AM -0700, Toshi Kani wrote: > > With this change, there will be no caller to walk_iomem_res(). Should > > we remove walk_iomem_res() altogether, or keep it for now as a > > deprecated func with the

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Borislav Petkov
On Mon, Jan 04, 2016 at 10:57:40AM -0700, Toshi Kani wrote: > With this change, there will be no caller to walk_iomem_res(). Should we > remove walk_iomem_res() altogether, or keep it for now as a deprecated func > with the checkpatch check? Yes, kill it on the spot so that people don't get

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Toshi Kani
On Mon, 2016-01-04 at 13:26 +0100, Borislav Petkov wrote: > On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote: > > Replied to Toshi old kernel will export the "GART" region for amd > > cards. > > So for old kernel and new kexec-tools we will have problem. > > > > I think add the GART

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Borislav Petkov
On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote: > Replied to Toshi old kernel will export the "GART" region for amd cards. > So for old kernel and new kexec-tools we will have problem. > > I think add the GART desc for compitibility purpose is doable, no? Just read your other mails

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
On 01/04/16 at 05:25pm, Dave Young wrote: > Hi, Toshi, > > On 12/25/15 at 03:09pm, Toshi Kani wrote: > > Change to call walk_iomem_res_desc() for searching resource entries > > with the following names: > > "ACPI Tables" > > "ACPI Non-volatile Storage" > > "Persistent Memory (legacy)" > >

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
Hi, Boris On 12/27/15 at 11:24am, Borislav Petkov wrote: > On Sun, Dec 27, 2015 at 10:12:57AM +0800, Minfei Huang wrote: > > You can refer the below link that you may get a clue about GART. This is > > the fisrt time kexec-tools tried to support to ignore GART region in 2nd > > kernel. > > > >

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
Hi, Toshi, On 12/25/15 at 03:09pm, Toshi Kani wrote: > Change to call walk_iomem_res_desc() for searching resource entries > with the following names: > "ACPI Tables" > "ACPI Non-volatile Storage" > "Persistent Memory (legacy)" > "Crash kernel" > > Note, the caller of walk_iomem_res() with

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Toshi Kani
On Mon, 2016-01-04 at 20:41 +0100, Borislav Petkov wrote: > On Mon, Jan 04, 2016 at 10:57:40AM -0700, Toshi Kani wrote: > > With this change, there will be no caller to walk_iomem_res(). Should > > we remove walk_iomem_res() altogether, or keep it for now as a > > deprecated func with the

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Borislav Petkov
On Mon, Jan 04, 2016 at 10:57:40AM -0700, Toshi Kani wrote: > With this change, there will be no caller to walk_iomem_res(). Should we > remove walk_iomem_res() altogether, or keep it for now as a deprecated func > with the checkpatch check? Yes, kill it on the spot so that people don't get

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
Hi, Boris On 12/27/15 at 11:24am, Borislav Petkov wrote: > On Sun, Dec 27, 2015 at 10:12:57AM +0800, Minfei Huang wrote: > > You can refer the below link that you may get a clue about GART. This is > > the fisrt time kexec-tools tried to support to ignore GART region in 2nd > > kernel. > > > >

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
On 01/04/16 at 05:25pm, Dave Young wrote: > Hi, Toshi, > > On 12/25/15 at 03:09pm, Toshi Kani wrote: > > Change to call walk_iomem_res_desc() for searching resource entries > > with the following names: > > "ACPI Tables" > > "ACPI Non-volatile Storage" > > "Persistent Memory (legacy)" > >

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
Hi, Toshi, On 12/25/15 at 03:09pm, Toshi Kani wrote: > Change to call walk_iomem_res_desc() for searching resource entries > with the following names: > "ACPI Tables" > "ACPI Non-volatile Storage" > "Persistent Memory (legacy)" > "Crash kernel" > > Note, the caller of walk_iomem_res() with

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Borislav Petkov
On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote: > Replied to Toshi old kernel will export the "GART" region for amd cards. > So for old kernel and new kexec-tools we will have problem. > > I think add the GART desc for compitibility purpose is doable, no? Just read your other mails

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
On 01/04/16 at 01:26pm, Borislav Petkov wrote: > On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote: > > Replied to Toshi old kernel will export the "GART" region for amd cards. > > So for old kernel and new kexec-tools we will have problem. > > > > I think add the GART desc for

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Toshi Kani
On Mon, 2016-01-04 at 13:26 +0100, Borislav Petkov wrote: > On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote: > > Replied to Toshi old kernel will export the "GART" region for amd > > cards. > > So for old kernel and new kexec-tools we will have problem. > > > > I think add the GART

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2015-12-27 Thread Borislav Petkov
On Sun, Dec 27, 2015 at 10:12:57AM +0800, Minfei Huang wrote: > You can refer the below link that you may get a clue about GART. This is > the fisrt time kexec-tools tried to support to ignore GART region in 2nd > kernel. > > http://lists.infradead.org/pipermail/kexec/2008-December/003096.html

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2015-12-27 Thread Borislav Petkov
On Sun, Dec 27, 2015 at 10:12:57AM +0800, Minfei Huang wrote: > You can refer the below link that you may get a clue about GART. This is > the fisrt time kexec-tools tried to support to ignore GART region in 2nd > kernel. > > http://lists.infradead.org/pipermail/kexec/2008-December/003096.html

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2015-12-26 Thread Minfei Huang
On 12/26/15 at 05:31pm, Toshi Kani wrote: > + cc: kexec list > > On 12/26/2015 3:38 AM, Borislav Petkov wrote: > >On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote: > >>Change to call walk_iomem_res_desc() for searching resource entries > >>with the following names: > >> "ACPI Tables" >

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2015-12-26 Thread Toshi Kani
On 12/26/2015 9:05 AM, Minfei Huang wrote: Ccing kexec maillist. On 12/25/15 at 03:09pm, Toshi Kani wrote: diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c index c245085..e2bd737 100644 --- a/kernel/kexec_file.c +++ b/kernel/kexec_file.c @@ -522,10 +522,10 @@ int kexec_add_buffer(struct

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2015-12-26 Thread Toshi Kani
+ cc: kexec list On 12/26/2015 3:38 AM, Borislav Petkov wrote: On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote: Change to call walk_iomem_res_desc() for searching resource entries with the following names: "ACPI Tables" "ACPI Non-volatile Storage" "Persistent Memory (legacy)"

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2015-12-26 Thread Minfei Huang
Ccing kexec maillist. On 12/25/15 at 03:09pm, Toshi Kani wrote: > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > index c245085..e2bd737 100644 > --- a/kernel/kexec_file.c > +++ b/kernel/kexec_file.c > @@ -522,10 +522,10 @@ int kexec_add_buffer(struct kimage *image, char > *buffer,

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2015-12-26 Thread Borislav Petkov
On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote: > Change to call walk_iomem_res_desc() for searching resource entries > with the following names: > "ACPI Tables" > "ACPI Non-volatile Storage" > "Persistent Memory (legacy)" > "Crash kernel" > > Note, the caller of walk_iomem_res()

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2015-12-26 Thread Minfei Huang
Ccing kexec maillist. On 12/25/15 at 03:09pm, Toshi Kani wrote: > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > index c245085..e2bd737 100644 > --- a/kernel/kexec_file.c > +++ b/kernel/kexec_file.c > @@ -522,10 +522,10 @@ int kexec_add_buffer(struct kimage *image, char > *buffer,

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2015-12-26 Thread Borislav Petkov
On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote: > Change to call walk_iomem_res_desc() for searching resource entries > with the following names: > "ACPI Tables" > "ACPI Non-volatile Storage" > "Persistent Memory (legacy)" > "Crash kernel" > > Note, the caller of walk_iomem_res()

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2015-12-26 Thread Toshi Kani
+ cc: kexec list On 12/26/2015 3:38 AM, Borislav Petkov wrote: On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote: Change to call walk_iomem_res_desc() for searching resource entries with the following names: "ACPI Tables" "ACPI Non-volatile Storage" "Persistent Memory (legacy)"

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2015-12-26 Thread Minfei Huang
On 12/26/15 at 05:31pm, Toshi Kani wrote: > + cc: kexec list > > On 12/26/2015 3:38 AM, Borislav Petkov wrote: > >On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote: > >>Change to call walk_iomem_res_desc() for searching resource entries > >>with the following names: > >> "ACPI Tables" >

Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2015-12-26 Thread Toshi Kani
On 12/26/2015 9:05 AM, Minfei Huang wrote: Ccing kexec maillist. On 12/25/15 at 03:09pm, Toshi Kani wrote: diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c index c245085..e2bd737 100644 --- a/kernel/kexec_file.c +++ b/kernel/kexec_file.c @@ -522,10 +522,10 @@ int kexec_add_buffer(struct

[PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2015-12-25 Thread Toshi Kani
Change to call walk_iomem_res_desc() for searching resource entries with the following names: "ACPI Tables" "ACPI Non-volatile Storage" "Persistent Memory (legacy)" "Crash kernel" Note, the caller of walk_iomem_res() with "GART" is left unchanged because this entry may be initialized by

[PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search

2015-12-25 Thread Toshi Kani
Change to call walk_iomem_res_desc() for searching resource entries with the following names: "ACPI Tables" "ACPI Non-volatile Storage" "Persistent Memory (legacy)" "Crash kernel" Note, the caller of walk_iomem_res() with "GART" is left unchanged because this entry may be initialized by