Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-12 Thread Ivajlo Dimitrov
On 12.12.2013 21:55, Ben Hutchings wrote: On Wed, 2013-12-11 at 16:53 -0600, Dan Williams wrote: On Wed, 2013-12-11 at 22:15 +, Ben Hutchings wrote: On Wed, 2013-12-11 at 23:35 +0200, Ivajlo Dimitrov wrote: On 11.12.2013 23:17, Ben Hutchings wrote: I think that's an even worse idea.

Re: Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-12 Thread Ben Hutchings
On Wed, 2013-12-11 at 16:53 -0600, Dan Williams wrote: > On Wed, 2013-12-11 at 22:15 +, Ben Hutchings wrote: > > On Wed, 2013-12-11 at 23:35 +0200, Ivajlo Dimitrov wrote: > > > On 11.12.2013 23:17, Ben Hutchings wrote: > > > > I think that's an even worse idea. This is not firmware and it

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-12 Thread Sergei Shtylyov
Hello. On 12-12-2013 2:36, Ivajlo Dimitrov wrote: 2. NVRAM reading is done by a tiny driver that is loaded based on the platform name and updates the DT node in memory. (But I don't know how wl1251 should decide to defer probing if it's probed before that other driver.) Ben. Maybe a

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-12 Thread Pavel Machek
On Wed 2013-12-11 21:17:34, Ben Hutchings wrote: > On Tue, 2013-12-10 at 18:52 +0100, Pali Rohár wrote: > > On Tuesday 10 December 2013 18:49:22 Dan Williams wrote: > > > On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: > > > > On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: > > > > >

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-12 Thread Pavel Machek
On Wed 2013-12-11 21:17:34, Ben Hutchings wrote: On Tue, 2013-12-10 at 18:52 +0100, Pali Rohár wrote: On Tuesday 10 December 2013 18:49:22 Dan Williams wrote: On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: On Tuesday 10

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-12 Thread Sergei Shtylyov
Hello. On 12-12-2013 2:36, Ivajlo Dimitrov wrote: 2. NVRAM reading is done by a tiny driver that is loaded based on the platform name and updates the DT node in memory. (But I don't know how wl1251 should decide to defer probing if it's probed before that other driver.) Ben. Maybe a

Re: Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-12 Thread Ben Hutchings
On Wed, 2013-12-11 at 16:53 -0600, Dan Williams wrote: On Wed, 2013-12-11 at 22:15 +, Ben Hutchings wrote: On Wed, 2013-12-11 at 23:35 +0200, Ivajlo Dimitrov wrote: On 11.12.2013 23:17, Ben Hutchings wrote: I think that's an even worse idea. This is not firmware and it already

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-12 Thread Ivajlo Dimitrov
On 12.12.2013 21:55, Ben Hutchings wrote: On Wed, 2013-12-11 at 16:53 -0600, Dan Williams wrote: On Wed, 2013-12-11 at 22:15 +, Ben Hutchings wrote: On Wed, 2013-12-11 at 23:35 +0200, Ivajlo Dimitrov wrote: On 11.12.2013 23:17, Ben Hutchings wrote: I think that's an even worse idea.

Re: Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Dan Williams
On Wed, 2013-12-11 at 22:15 +, Ben Hutchings wrote: > On Wed, 2013-12-11 at 23:35 +0200, Ivajlo Dimitrov wrote: > > On 11.12.2013 23:17, Ben Hutchings wrote: > > > I think that's an even worse idea. This is not firmware and it already > > > exists in separate storage. > > > > > > I think that

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ivajlo Dimitrov
On 12.12.2013 00:15, Ben Hutchings wrote: 2. NVRAM reading is done by a tiny driver that is loaded based on the platform name and updates the DT node in memory. (But I don't know how wl1251 should decide to defer probing if it's probed before that other driver.) Ben. Maybe a "hwmac"

Re: Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ben Hutchings
On Wed, 2013-12-11 at 23:35 +0200, Ivajlo Dimitrov wrote: > On 11.12.2013 23:17, Ben Hutchings wrote: > > I think that's an even worse idea. This is not firmware and it already > > exists in separate storage. > > > > I think that rx51_init_wl1251() in > >

Re: Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ivajlo Dimitrov
On 11.12.2013 23:17, Ben Hutchings wrote: I think that's an even worse idea. This is not firmware and it already exists in separate storage. I think that rx51_init_wl1251() in arch/arm/mach-omap2/board-rx51-peripherals.c should either copy the MAC address out of NVRAM, or if it's too early to

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ben Hutchings
On Wed, 2013-12-11 at 21:17 +, Ben Hutchings wrote: > On Tue, 2013-12-10 at 18:52 +0100, Pali Rohár wrote: [...] > > Maybe another way could be to use request_firmware to load address > > from userspace... Or what do you think? > > I think that's an even worse idea. This is not firmware and

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ben Hutchings
On Tue, 2013-12-10 at 20:31 +0100, Pali Rohár wrote: [...] > So, if you like this idea, can you help me how to write udev rule > which will run my own program (it print mac address) and send mac > address when driver ask for mac address in request_firmware? > Problem is that default udev rule

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ben Hutchings
On Tue, 2013-12-10 at 18:52 +0100, Pali Rohár wrote: > On Tuesday 10 December 2013 18:49:22 Dan Williams wrote: > > On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: > > > On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: > > > > On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: > > >

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ben Hutchings
On Tue, 2013-12-10 at 18:52 +0100, Pali Rohár wrote: On Tuesday 10 December 2013 18:49:22 Dan Williams wrote: On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: Pali Rohár

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ben Hutchings
On Tue, 2013-12-10 at 20:31 +0100, Pali Rohár wrote: [...] So, if you like this idea, can you help me how to write udev rule which will run my own program (it print mac address) and send mac address when driver ask for mac address in request_firmware? Problem is that default udev rule for

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ben Hutchings
On Wed, 2013-12-11 at 21:17 +, Ben Hutchings wrote: On Tue, 2013-12-10 at 18:52 +0100, Pali Rohár wrote: [...] Maybe another way could be to use request_firmware to load address from userspace... Or what do you think? I think that's an even worse idea. This is not firmware and it

Re: Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ivajlo Dimitrov
On 11.12.2013 23:17, Ben Hutchings wrote: I think that's an even worse idea. This is not firmware and it already exists in separate storage. I think that rx51_init_wl1251() in arch/arm/mach-omap2/board-rx51-peripherals.c should either copy the MAC address out of NVRAM, or if it's too early to

Re: Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ben Hutchings
On Wed, 2013-12-11 at 23:35 +0200, Ivajlo Dimitrov wrote: On 11.12.2013 23:17, Ben Hutchings wrote: I think that's an even worse idea. This is not firmware and it already exists in separate storage. I think that rx51_init_wl1251() in arch/arm/mach-omap2/board-rx51-peripherals.c should

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Ivajlo Dimitrov
On 12.12.2013 00:15, Ben Hutchings wrote: 2. NVRAM reading is done by a tiny driver that is loaded based on the platform name and updates the DT node in memory. (But I don't know how wl1251 should decide to defer probing if it's probed before that other driver.) Ben. Maybe a hwmac property

Re: Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-11 Thread Dan Williams
On Wed, 2013-12-11 at 22:15 +, Ben Hutchings wrote: On Wed, 2013-12-11 at 23:35 +0200, Ivajlo Dimitrov wrote: On 11.12.2013 23:17, Ben Hutchings wrote: I think that's an even worse idea. This is not firmware and it already exists in separate storage. I think that

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Pali Rohár
On Tuesday 10 December 2013 20:22:19 Dan Williams wrote: > On Tue, 2013-12-10 at 18:52 +0100, Pali Rohár wrote: > > On Tuesday 10 December 2013 18:49:22 Dan Williams wrote: > > > On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: > > > > On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: > >

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Dan Williams
On Tue, 2013-12-10 at 18:52 +0100, Pali Rohár wrote: > On Tuesday 10 December 2013 18:49:22 Dan Williams wrote: > > On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: > > > On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: > > > > On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: > > >

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Pali Rohár
On Tuesday 10 December 2013 18:49:22 Dan Williams wrote: > On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: > > On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: > > > On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: > > > > Pali Rohár writes: > > > > > Driver wl1251 generating mac

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Dan Williams
On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: > On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: > > On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: > > > Pali Rohár writes: > > > > Driver wl1251 generating mac address randomly at startup > > > > and there is no way to set

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Pali Rohár
On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: > On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: > > Pali Rohár writes: > > > Driver wl1251 generating mac address randomly at startup > > > and there is no way to set permanent mac address via > > > SET_IEEE80211_PERM_ADDR. This

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Pali Rohár
On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: > Pali Rohár writes: > > Driver wl1251 generating mac address randomly at startup and > > there is no way to set permanent mac address via > > SET_IEEE80211_PERM_ADDR. This patch export sysfs file which > > can set permanent mac address by

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Kalle Valo
Pali Rohár writes: > Driver wl1251 generating mac address randomly at startup and there is no way > to > set permanent mac address via SET_IEEE80211_PERM_ADDR. This patch export sysfs > file which can set permanent mac address by userspace helper program. Patch is > needed for devices which do

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Dan Williams
On Tue, 2013-12-10 at 18:52 +0100, Pali Rohár wrote: On Tuesday 10 December 2013 18:49:22 Dan Williams wrote: On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: Pali Rohár

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Pali Rohár
On Tuesday 10 December 2013 20:22:19 Dan Williams wrote: On Tue, 2013-12-10 at 18:52 +0100, Pali Rohár wrote: On Tuesday 10 December 2013 18:49:22 Dan Williams wrote: On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: On

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Kalle Valo
Pali Rohár pali.ro...@gmail.com writes: Driver wl1251 generating mac address randomly at startup and there is no way to set permanent mac address via SET_IEEE80211_PERM_ADDR. This patch export sysfs file which can set permanent mac address by userspace helper program. Patch is needed for

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Pali Rohár
On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: Pali Rohár pali.ro...@gmail.com writes: Driver wl1251 generating mac address randomly at startup and there is no way to set permanent mac address via SET_IEEE80211_PERM_ADDR. This patch export sysfs file which can set permanent mac

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Pali Rohár
On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: Pali Rohár pali.ro...@gmail.com writes: Driver wl1251 generating mac address randomly at startup and there is no way to set permanent mac address via SET_IEEE80211_PERM_ADDR.

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Dan Williams
On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: Pali Rohár pali.ro...@gmail.com writes: Driver wl1251 generating mac address randomly at startup and there is no way to

Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-10 Thread Pali Rohár
On Tuesday 10 December 2013 18:49:22 Dan Williams wrote: On Tue, 2013-12-10 at 18:14 +0100, Pali Rohár wrote: On Tuesday 10 December 2013 17:10:50 Pali Rohár wrote: On Tuesday 10 December 2013 16:49:23 Kalle Valo wrote: Pali Rohár pali.ro...@gmail.com writes: Driver wl1251

[PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-08 Thread Pali Rohár
Driver wl1251 generating mac address randomly at startup and there is no way to set permanent mac address via SET_IEEE80211_PERM_ADDR. This patch export sysfs file which can set permanent mac address by userspace helper program. Patch is needed for devices which do not store mac address in

[PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address

2013-12-08 Thread Pali Rohár
Driver wl1251 generating mac address randomly at startup and there is no way to set permanent mac address via SET_IEEE80211_PERM_ADDR. This patch export sysfs file which can set permanent mac address by userspace helper program. Patch is needed for devices which do not store mac address in