Re: [PATCH v2 15/19] PM / devfreq: tegra: Synchronize IRQ after masking it in hardware

2019-04-16 Thread Dmitry Osipenko
16.04.2019 10:41, Chanwoo Choi пишет: > Hi, > > In this patchset, > the patch11 adds new 'disable_interrupt' goto statement > and then patch15 removes 'disable_interrupt' goto statement again. > Actually, it is inefficient. > > If you change the order of patches, > you could remove this stuff. O

Re: [PATCH v2 15/19] PM / devfreq: tegra: Synchronize IRQ after masking it in hardware

2019-04-16 Thread Chanwoo Choi
Hi, In this patchset, the patch11 adds new 'disable_interrupt' goto statement and then patch15 removes 'disable_interrupt' goto statement again. Actually, it is inefficient. If you change the order of patches, you could remove this stuff. On 19. 4. 15. 오후 11:55, Dmitry Osipenko wrote: > There is

[PATCH v2 15/19] PM / devfreq: tegra: Synchronize IRQ after masking it in hardware

2019-04-15 Thread Dmitry Osipenko
There is no guarantee that interrupt handling isn't running in parallel, hence it is necessary to synchronize IRQ in order to ensure that interrupt is indeed disabled. Signed-off-by: Dmitry Osipenko --- drivers/devfreq/tegra-devfreq.c | 33 - 1 file changed, 16 in