Re: [PATCH v2 15/21] ALSA: oxygen: use match_string() helper

2018-05-31 Thread Takashi Iwai
On Thu, 31 May 2018 21:02:05 +0200, Andy Shevchenko wrote: > > On Thu, May 31, 2018 at 9:59 PM, Takashi Iwai wrote: > > On Thu, 31 May 2018 20:41:36 +0200, > > Andy Shevchenko wrote: > >> On Thu, May 31, 2018 at 2:11 PM, Yisheng Xie > >> wrote: > > >> > + j = match_string(known_c

Re: [PATCH v2 15/21] ALSA: oxygen: use match_string() helper

2018-05-31 Thread Andy Shevchenko
On Thu, May 31, 2018 at 9:59 PM, Takashi Iwai wrote: > On Thu, 31 May 2018 20:41:36 +0200, > Andy Shevchenko wrote: >> On Thu, May 31, 2018 at 2:11 PM, Yisheng Xie wrote: >> > + j = match_string(known_ctl_names, CONTROL_COUNT, >> > ctl->id.name); >> > + if (j >= 0) {

Re: [PATCH v2 15/21] ALSA: oxygen: use match_string() helper

2018-05-31 Thread Takashi Iwai
On Thu, 31 May 2018 20:41:36 +0200, Andy Shevchenko wrote: > > On Thu, May 31, 2018 at 2:11 PM, Yisheng Xie wrote: > > match_string() returns the index of an array for a matching string, > > which can be used instead of open coded variant. > > Sorry, didn't notice before one thing: > > > +

Re: [PATCH v2 15/21] ALSA: oxygen: use match_string() helper

2018-05-31 Thread Andy Shevchenko
On Thu, May 31, 2018 at 9:43 PM, Takashi Iwai wrote: > On Thu, 31 May 2018 20:40:28 +0200, > Andy Shevchenko wrote: >> >> On Thu, May 31, 2018 at 9:39 PM, Takashi Iwai wrote: >> > Applied, thanks. >> >> Is it too late for nitpick? > > Depends :) See my previous mail then. -- With Best Regards

Re: [PATCH v2 15/21] ALSA: oxygen: use match_string() helper

2018-05-31 Thread Takashi Iwai
On Thu, 31 May 2018 20:40:28 +0200, Andy Shevchenko wrote: > > On Thu, May 31, 2018 at 9:39 PM, Takashi Iwai wrote: > > On Thu, 31 May 2018 13:11:20 +0200, > > Yisheng Xie wrote: > >> > >> match_string() returns the index of an array for a matching string, > >> which can be used instead of open c

Re: [PATCH v2 15/21] ALSA: oxygen: use match_string() helper

2018-05-31 Thread Andy Shevchenko
On Thu, May 31, 2018 at 2:11 PM, Yisheng Xie wrote: > match_string() returns the index of an array for a matching string, > which can be used instead of open coded variant. Sorry, didn't notice before one thing: > + j = match_string(known_ctl_names, CONTROL_COUNT, > ctl->id.name);

Re: [PATCH v2 15/21] ALSA: oxygen: use match_string() helper

2018-05-31 Thread Andy Shevchenko
On Thu, May 31, 2018 at 9:39 PM, Takashi Iwai wrote: > On Thu, 31 May 2018 13:11:20 +0200, > Yisheng Xie wrote: >> >> match_string() returns the index of an array for a matching string, >> which can be used instead of open coded variant. >> >> Cc: Clemens Ladisch >> Cc: Jaroslav Kysela >> Cc: Ta

Re: [PATCH v2 15/21] ALSA: oxygen: use match_string() helper

2018-05-31 Thread Takashi Iwai
On Thu, 31 May 2018 13:11:20 +0200, Yisheng Xie wrote: > > match_string() returns the index of an array for a matching string, > which can be used instead of open coded variant. > > Cc: Clemens Ladisch > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: alsa-de...@alsa-project.org > Signed-off-by:

[PATCH v2 15/21] ALSA: oxygen: use match_string() helper

2018-05-31 Thread Yisheng Xie
match_string() returns the index of an array for a matching string, which can be used instead of open coded variant. Cc: Clemens Ladisch Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-de...@alsa-project.org Signed-off-by: Yisheng Xie --- v2: - do not change the type of i - per Andy sound/pci