Re: [PATCH v2 17/18] cpufreq: add support for CPU DVFS based on SCMI message protocol

2017-08-09 Thread Sudeep Holla
On 09/08/17 11:06, Viresh Kumar wrote: > On 09-08-17, 10:59, Sudeep Holla wrote: >> On 09/08/17 05:18, Viresh Kumar wrote: > >>> This stores the same handle pointer which is stored in the global variable >>> below. Right? Why keep a local variable here at all ? >> >> Yes, you are right.

Re: [PATCH v2 17/18] cpufreq: add support for CPU DVFS based on SCMI message protocol

2017-08-09 Thread Sudeep Holla
On 09/08/17 11:06, Viresh Kumar wrote: > On 09-08-17, 10:59, Sudeep Holla wrote: >> On 09/08/17 05:18, Viresh Kumar wrote: > >>> This stores the same handle pointer which is stored in the global variable >>> below. Right? Why keep a local variable here at all ? >> >> Yes, you are right.

Re: [PATCH v2 17/18] cpufreq: add support for CPU DVFS based on SCMI message protocol

2017-08-09 Thread Viresh Kumar
On 09-08-17, 10:59, Sudeep Holla wrote: > On 09/08/17 05:18, Viresh Kumar wrote: > > This stores the same handle pointer which is stored in the global variable > > below. Right? Why keep a local variable here at all ? > > Yes, you are right. Initially, started with just private pointers and >

Re: [PATCH v2 17/18] cpufreq: add support for CPU DVFS based on SCMI message protocol

2017-08-09 Thread Viresh Kumar
On 09-08-17, 10:59, Sudeep Holla wrote: > On 09/08/17 05:18, Viresh Kumar wrote: > > This stores the same handle pointer which is stored in the global variable > > below. Right? Why keep a local variable here at all ? > > Yes, you are right. Initially, started with just private pointers and >

Re: [PATCH v2 17/18] cpufreq: add support for CPU DVFS based on SCMI message protocol

2017-08-09 Thread Sudeep Holla
On 09/08/17 05:18, Viresh Kumar wrote: > On 04-08-17, 15:31, Sudeep Holla wrote: > > I don't think its the Microsoft exchange server which screwed up tabs and > spaces, but you. > Indeed, copy paste to blame ;) >> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm >>

Re: [PATCH v2 17/18] cpufreq: add support for CPU DVFS based on SCMI message protocol

2017-08-09 Thread Sudeep Holla
On 09/08/17 05:18, Viresh Kumar wrote: > On 04-08-17, 15:31, Sudeep Holla wrote: > > I don't think its the Microsoft exchange server which screwed up tabs and > spaces, but you. > Indeed, copy paste to blame ;) >> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm >>

Re: [PATCH v2 17/18] cpufreq: add support for CPU DVFS based on SCMI message protocol

2017-08-08 Thread Viresh Kumar
On 04-08-17, 15:31, Sudeep Holla wrote: I don't think its the Microsoft exchange server which screwed up tabs and spaces, but you. > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index 2011fec2d6ad..c34633855bc7 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++

Re: [PATCH v2 17/18] cpufreq: add support for CPU DVFS based on SCMI message protocol

2017-08-08 Thread Viresh Kumar
On 04-08-17, 15:31, Sudeep Holla wrote: I don't think its the Microsoft exchange server which screwed up tabs and spaces, but you. > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index 2011fec2d6ad..c34633855bc7 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++

[PATCH v2 17/18] cpufreq: add support for CPU DVFS based on SCMI message protocol

2017-08-04 Thread Sudeep Holla
On some ARM based systems, a separate Cortex-M based System Control Processor(SCP) provides the overall power, clock, reset and system control including CPU DVFS. SCMI Message Protocol is used to communicate with the SCP. This patch adds a cpufreq driver for such systems using SCMI interface to

[PATCH v2 17/18] cpufreq: add support for CPU DVFS based on SCMI message protocol

2017-08-04 Thread Sudeep Holla
On some ARM based systems, a separate Cortex-M based System Control Processor(SCP) provides the overall power, clock, reset and system control including CPU DVFS. SCMI Message Protocol is used to communicate with the SCP. This patch adds a cpufreq driver for such systems using SCMI interface to