Re: [PATCH v2 2/2] ASoC: fsl_asrc: always use internal ratio

2020-07-20 Thread Shengjiu Wang
On Fri, Jul 17, 2020 at 5:58 PM Arnaud Ferraris wrote: > > > > Le 17/07/2020 à 01:37, Nicolin Chen a écrit : > >> @@ -507,8 +507,7 @@ static int fsl_asrc_config_pair(struct fsl_asrc_pair > >> *pair, bool use_ideal_rate) > >> > >> /* Enable Ideal Ratio mode */ > > > > The code is against the

Re: [PATCH v2 2/2] ASoC: fsl_asrc: always use internal ratio

2020-07-17 Thread Arnaud Ferraris
Le 17/07/2020 à 01:37, Nicolin Chen a écrit : >> @@ -507,8 +507,7 @@ static int fsl_asrc_config_pair(struct fsl_asrc_pair >> *pair, bool use_ideal_rate) >> >> /* Enable Ideal Ratio mode */ > > The code is against the comments now -- need to update this line. It isn't, the following cod

Re: [PATCH v2 2/2] ASoC: fsl_asrc: always use internal ratio

2020-07-16 Thread Nicolin Chen
On Thu, Jul 16, 2020 at 05:13:54PM +0200, Arnaud Ferraris wrote: > Even though the current driver calculates the dividers to be used > depending on the clocks and sample rates, enabling the internal ratio > can lead to noticeable improvements in the audio quality, based on my > testing. > > As sta

[PATCH v2 2/2] ASoC: fsl_asrc: always use internal ratio

2020-07-16 Thread Arnaud Ferraris
Even though the current driver calculates the dividers to be used depending on the clocks and sample rates, enabling the internal ratio can lead to noticeable improvements in the audio quality, based on my testing. As stated in the documentation, "When USRx=1 and IDRx=0, ASRC internal measured rat