Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

Hi Markus, On Mon, Oct 3, 2016 at 3:47 PM, SF Markus Elfring wrote: >>> Did you notice the check "IS_ERR(bp_data)" and the corresponding reaction >>> in this update suggestion? >> >> Yes, but bp_data may still be a valid (as in "not an error") value. > > Thanks for

Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

Hi Markus, On Mon, Oct 3, 2016 at 3:47 PM, SF Markus Elfring wrote: >>> Did you notice the check "IS_ERR(bp_data)" and the corresponding reaction >>> in this update suggestion? >> >> Yes, but bp_data may still be a valid (as in "not an error") value. > > Thanks for your constructive feedback. >

Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

>> Did you notice the check "IS_ERR(bp_data)" and the corresponding reaction >> in this update suggestion? > > Yes, but bp_data may still be a valid (as in "not an error") value. Thanks for your constructive feedback. > Your commit a1708a2eaded836b ("KVM: s390: Improve determination of sizes

Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

>> Did you notice the check "IS_ERR(bp_data)" and the corresponding reaction >> in this update suggestion? > > Yes, but bp_data may still be a valid (as in "not an error") value. Thanks for your constructive feedback. > Your commit a1708a2eaded836b ("KVM: s390: Improve determination of sizes

Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

Hi Markus, On Mon, Oct 3, 2016 at 2:28 PM, SF Markus Elfring wrote: >>> - if (!bp_data) { >>> - ret = -ENOMEM; >>> - goto error; >>> - } >>> - >>> - if (copy_from_user(bp_data, >>> -

Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

Hi Markus, On Mon, Oct 3, 2016 at 2:28 PM, SF Markus Elfring wrote: >>> - if (!bp_data) { >>> - ret = -ENOMEM; >>> - goto error; >>> - } >>> - >>> - if (copy_from_user(bp_data, >>> - dbg->arch.hw_bp, >>> -

Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

>> - if (!bp_data) { >> - ret = -ENOMEM; >> - goto error; >> - } >> - >> - if (copy_from_user(bp_data, >> - dbg->arch.hw_bp, >> - sizeof(*bp_data) * dbg->arch.nr_hw_bp)) { >> - ret =

Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

>> - if (!bp_data) { >> - ret = -ENOMEM; >> - goto error; >> - } >> - >> - if (copy_from_user(bp_data, >> - dbg->arch.hw_bp, >> - sizeof(*bp_data) * dbg->arch.nr_hw_bp)) { >> - ret =

Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

Hi Markus, On Wed, Aug 24, 2016 at 8:40 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 24 Aug 2016 20:10:09 +0200 > > * Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. >

Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

Hi Markus, On Wed, Aug 24, 2016 at 8:40 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 24 Aug 2016 20:10:09 +0200 > > * Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > This issue was detected by using the Coccinelle software.

Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

On Wed, 24 Aug 2016 20:40:03 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 24 Aug 2016 20:10:09 +0200 > > * Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > >

Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

On Wed, 24 Aug 2016 20:40:03 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 24 Aug 2016 20:10:09 +0200 > > * Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > This issue was detected by using the Coccinelle software. > > *

[PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

From: Markus Elfring Date: Wed, 24 Aug 2016 20:10:09 +0200 * Reuse existing functionality from memdup_user() instead of keeping duplicate source code. This issue was detected by using the Coccinelle software. * Return directly if this copy operation failed.

[PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code

From: Markus Elfring Date: Wed, 24 Aug 2016 20:10:09 +0200 * Reuse existing functionality from memdup_user() instead of keeping duplicate source code. This issue was detected by using the Coccinelle software. * Return directly if this copy operation failed. Reviewed-by: David Hildenbrand