Re: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

2014-09-10 Thread Murali Karicheri
On 09/10/2014 04:22 AM, Arnd Bergmann wrote: On Tuesday 09 September 2014 18:50:13 Murali Karicheri wrote: My mistake. It is the device ID, not vendor ID. The PCI driver supports PCI h/w on K2HK, K2E and K2L SoCs for which PCI device IDs are assigned as +#define PCIE_RC_K2HK 0xb008 +#

Re: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

2014-09-10 Thread Arnd Bergmann
On Tuesday 09 September 2014 18:50:13 Murali Karicheri wrote: > My mistake. It is the device ID, not vendor ID. The PCI driver supports > PCI h/w on K2HK, K2E and K2L SoCs for which PCI device IDs are assigned as > > +#define PCIE_RC_K2HK 0xb008 > +#define PCIE_RC_K2E0xb009

Re: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

2014-09-09 Thread Murali Karicheri
On 09/09/2014 05:52 PM, Arnd Bergmann wrote: On Tuesday 09 September 2014 17:49:19 Murali Karicheri wrote: Actually this is an inteded. The vendor ID is in a register indicated by reg offset and as per the device spec, it needs to be read and updated by the software. Now since multiple instances

Re: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

2014-09-09 Thread Arnd Bergmann
On Tuesday 09 September 2014 17:49:19 Murali Karicheri wrote: > Actually this is an inteded. The vendor ID is in a register indicated by > reg offset and as per the device spec, it needs to be read and updated > by the software. Now since multiple instances of PCI device needs to be > read the sa

Re: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

2014-09-09 Thread Murali Karicheri
On 09/09/2014 05:49 PM, Murali Karicheri wrote: On 09/09/2014 05:09 PM, Arnd Bergmann wrote: On Tuesday 09 September 2014 16:42:46 Murali Karicheri wrote: /* update the Vendor ID */ - vendor_device_id = readl(ks_pcie->va_reg_pciid); - writew((vendor_device_id>> 16), pp->dbi_base + PCI_DEVICE_I

Re: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

2014-09-09 Thread Murali Karicheri
On 09/09/2014 05:09 PM, Arnd Bergmann wrote: On Tuesday 09 September 2014 16:42:46 Murali Karicheri wrote: /* update the Vendor ID */ -vendor_device_id = readl(ks_pcie->va_reg_pciid); -writew((vendor_device_id>> 16), pp->dbi_base + PCI_DEVICE_ID); +writew(ks_pcie->device_id,

Re: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

2014-09-09 Thread Arnd Bergmann
On Tuesday 09 September 2014 16:42:46 Murali Karicheri wrote: > >> > >> /* update the Vendor ID */ > >> -vendor_device_id = readl(ks_pcie->va_reg_pciid); > >> -writew((vendor_device_id>> 16), pp->dbi_base + PCI_DEVICE_ID); > >> +writew(ks_pcie->device_id, pp->dbi_base + PCI_DEVICE

Re: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

2014-09-09 Thread Murali Karicheri
On 09/09/2014 04:28 PM, Arnd Bergmann wrote: On Tuesday 09 September 2014 16:17:15 Murali Karicheri wrote: K2E SoC has two PCI ports. The SATA controller is connected to second PCI port (port 1). This patch enhances the driver to support multiple ports. Update the DT Documentation for the new a

Re: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

2014-09-09 Thread Arnd Bergmann
On Tuesday 09 September 2014 16:17:15 Murali Karicheri wrote: > K2E SoC has two PCI ports. The SATA controller is connected to second > PCI port (port 1). This patch enhances the driver to support multiple > ports. > > Update the DT Documentation for the new attribute, ti,pcie-port and > remove th

[PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

2014-09-09 Thread Murali Karicheri
K2E SoC has two PCI ports. The SATA controller is connected to second PCI port (port 1). This patch enhances the driver to support multiple ports. Update the DT Documentation for the new attribute, ti,pcie-port and remove the note for bootargs as this is no longer needed. Signed-off-by: Murali Ka