subject:"\[PATCH v2 2\/2\] btrfs\: reada\: Fix returned errno code"

Re: [PATCH v2 2/2] btrfs: reada: Fix returned errno code

2015-09-25 Thread David Sterba

On Thu, Sep 24, 2015 at 08:13:33PM +0100, Luis de Bethencourt wrote: > reada is using -1 instead of the -ENOMEM defined macro to specify that > a buffer allocation failed. Since the error number is propagated, the > caller will get a -EPERM which is the wrong error condition. > > Also, updating th

[PATCH v2 2/2] btrfs: reada: Fix returned errno code

2015-09-24 Thread Luis de Bethencourt

reada is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Since the error number is propagated, the caller will get a -EPERM which is the wrong error condition. Also, updating the caller to return the exact value from reada_add_block. Smatch tool warning: