Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-07 Thread Harini Katakam
Hi Peter, On Sun, Apr 6, 2014 at 5:13 AM, Peter Crosthwaite wrote: > On Sat, Apr 5, 2014 at 4:05 PM, Harini Katakam > wrote: >> Hi Peter, >> >> On Sat, Apr 5, 2014 at 4:44 AM, Peter Crosthwaite >> wrote: >>> On Sat, Apr 5, 2014 at 12:30 AM, Harini Katakam >>> wrote: Hi, On Fri,

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-05 Thread Peter Crosthwaite
On Sat, Apr 5, 2014 at 4:05 PM, Harini Katakam wrote: > Hi Peter, > > On Sat, Apr 5, 2014 at 4:44 AM, Peter Crosthwaite > wrote: >> On Sat, Apr 5, 2014 at 12:30 AM, Harini Katakam >> wrote: >>> Hi, >>> >>> On Fri, Apr 4, 2014 at 7:38 PM, Harini Katakam >>> wrote: Hi Mark, On Fri,

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi Peter, On Sat, Apr 5, 2014 at 4:44 AM, Peter Crosthwaite wrote: > On Sat, Apr 5, 2014 at 12:30 AM, Harini Katakam > wrote: >> Hi, >> >> On Fri, Apr 4, 2014 at 7:38 PM, Harini Katakam >> wrote: >>> Hi Mark, >>> >>> On Fri, Apr 4, 2014 at 6:16 PM, Mark Brown wrote: On Fri, Apr 04, 2014 a

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Peter Crosthwaite
On Sat, Apr 5, 2014 at 12:30 AM, Harini Katakam wrote: > Hi, > > On Fri, Apr 4, 2014 at 7:38 PM, Harini Katakam > wrote: >> Hi Mark, >> >> On Fri, Apr 4, 2014 at 6:16 PM, Mark Brown wrote: >>> On Fri, Apr 04, 2014 at 05:44:23PM +0530, Harini Katakam wrote: On Fri, Apr 4, 2014 at 3:39 PM, Ma

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi Mark, On Fri, Apr 4, 2014 at 8:12 PM, Mark Brown wrote: > On Fri, Apr 04, 2014 at 07:38:14PM +0530, Harini Katakam wrote: > >> OK. I understand. >> Can you comment on the case where a decoder is used? > >> There is support for adding a decoder where extended slaves can be selected >> through t

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Mark Brown
On Fri, Apr 04, 2014 at 07:38:14PM +0530, Harini Katakam wrote: > OK. I understand. > Can you comment on the case where a decoder is used? > There is support for adding a decoder where extended slaves can be selected > through the IP's control register. > (This is not currently implemented in the

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi, On Fri, Apr 4, 2014 at 7:38 PM, Harini Katakam wrote: > Hi Mark, > > On Fri, Apr 4, 2014 at 6:16 PM, Mark Brown wrote: >> On Fri, Apr 04, 2014 at 05:44:23PM +0530, Harini Katakam wrote: >>> On Fri, Apr 4, 2014 at 3:39 PM, Mark Brown wrote: >>> > On Fri, Apr 04, 2014 at 08:30:38AM +0530, Har

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi Mark, On Fri, Apr 4, 2014 at 6:16 PM, Mark Brown wrote: > On Fri, Apr 04, 2014 at 05:44:23PM +0530, Harini Katakam wrote: >> On Fri, Apr 4, 2014 at 3:39 PM, Mark Brown wrote: >> > On Fri, Apr 04, 2014 at 08:30:38AM +0530, Harini Katakam wrote: > >> >> This IP can drive 4 slaves. >> >> The CS

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Mark Brown
On Fri, Apr 04, 2014 at 05:44:23PM +0530, Harini Katakam wrote: > On Fri, Apr 4, 2014 at 3:39 PM, Mark Brown wrote: > > On Fri, Apr 04, 2014 at 08:30:38AM +0530, Harini Katakam wrote: > >> This IP can drive 4 slaves. > >> The CS line to be driven is selected in spi device structure and > >> that

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi, On Fri, Apr 4, 2014 at 5:54 PM, Peter Crosthwaite wrote: > On Fri, Apr 4, 2014 at 10:14 PM, Harini Katakam > wrote: >> Hi Mark, >> >> On Fri, Apr 4, 2014 at 3:39 PM, Mark Brown wrote: >>> On Fri, Apr 04, 2014 at 08:30:38AM +0530, Harini Katakam wrote: On Fri, Apr 4, 2014 at 3:04 AM, Ma

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Peter Crosthwaite
On Fri, Apr 4, 2014 at 10:14 PM, Harini Katakam wrote: > Hi Mark, > > On Fri, Apr 4, 2014 at 3:39 PM, Mark Brown wrote: >> On Fri, Apr 04, 2014 at 08:30:38AM +0530, Harini Katakam wrote: >>> On Fri, Apr 4, 2014 at 3:04 AM, Mark Brown wrote: >>> > On Thu, Apr 03, 2014 at 04:40:31PM +0530, Harini

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Harini Katakam
Hi Mark, On Fri, Apr 4, 2014 at 3:39 PM, Mark Brown wrote: > On Fri, Apr 04, 2014 at 08:30:38AM +0530, Harini Katakam wrote: >> On Fri, Apr 4, 2014 at 3:04 AM, Mark Brown wrote: >> > On Thu, Apr 03, 2014 at 04:40:31PM +0530, Harini Katakam wrote: > >> >> +Optional properties: >> >> +- num-cs

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Michal Simek
On 04/04/2014 10:09 AM, Geert Uytterhoeven wrote: > Hi Harini, > > On Fri, Apr 4, 2014 at 5:00 AM, Harini Katakam > wrote: + num-cs = /bits/ 16 <4>; >>> >>> What's going on with the /bits/ - is this something that's required for >>> the property? >> >> The master->num-chipselect

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Mark Brown
On Fri, Apr 04, 2014 at 08:30:38AM +0530, Harini Katakam wrote: > On Fri, Apr 4, 2014 at 3:04 AM, Mark Brown wrote: > > On Thu, Apr 03, 2014 at 04:40:31PM +0530, Harini Katakam wrote: > >> +Optional properties: > >> +- num-cs : Number of chip selects used. > > How does this translate

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-04 Thread Geert Uytterhoeven
Hi Harini, On Fri, Apr 4, 2014 at 5:00 AM, Harini Katakam wrote: >>> + num-cs = /bits/ 16 <4>; >> >> What's going on with the /bits/ - is this something that's required for >> the property? > > The master->num-chipselect property is 16 bit but writing <4> here directly > leads to 0 be

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-03 Thread Harini Katakam
Hi Mark, On Fri, Apr 4, 2014 at 3:04 AM, Mark Brown wrote: > On Thu, Apr 03, 2014 at 04:40:31PM +0530, Harini Katakam wrote: > >> +Optional properties: >> +- num-cs : Number of chip selects used. > > How does this translate to the hardware? This IP can drive 4 slaves. The CS line to

Re: [PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-03 Thread Mark Brown
On Thu, Apr 03, 2014 at 04:40:31PM +0530, Harini Katakam wrote: > +Optional properties: > +- num-cs : Number of chip selects used. How does this translate to the hardware? > + num-cs = /bits/ 16 <4>; What's going on with the /bits/ - is this something that's required for

[PATCH v2 2/2] devicetree: Add devicetree bindings documentation for Cadence SPI

2014-04-03 Thread Harini Katakam
Add spi-cadence bindings documentation. Signed-off-by: Harini Katakam --- v2 changes: - Separate patch for bindings. - Add xilinx compatible string; Make compatible string first in the node. - Use property name num-cs. Make this property optional. --- .../devicetree/bindings/spi/spi-cadence.tx