Re: [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator

2018-04-13 Thread Robin Murphy
On 11/04/18 15:44, Pierre-Yves MORDRET wrote: Only 1 Hw Descriptor is allocated. Loop over required Hw descriptor for proper allocation. Signed-off-by: Pierre-Yves MORDRET --- Version history: v1: * Initial v2: * Fix kbuild warning format: /0x%08x/%pad/ --- --- dr

Re: [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator

2018-04-13 Thread Geert Uytterhoeven
Hi Vinod, On Fri, Apr 13, 2018 at 12:09 PM, Vinod Koul wrote: > On Fri, Apr 13, 2018 at 10:39:48AM +0200, Geert Uytterhoeven wrote: >> On Fri, Apr 13, 2018 at 6:02 AM, Vinod Koul wrote: >> > On Wed, Apr 11, 2018 at 04:44:39PM +0200, Pierre-Yves MORDRET wrote: >> > >> >> struct stm32_mdma_desc {

Re: [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator

2018-04-13 Thread Vinod Koul
On Fri, Apr 13, 2018 at 10:39:48AM +0200, Geert Uytterhoeven wrote: > Hi Vinod, > > On Fri, Apr 13, 2018 at 6:02 AM, Vinod Koul wrote: > > On Wed, Apr 11, 2018 at 04:44:39PM +0200, Pierre-Yves MORDRET wrote: > > > >> struct stm32_mdma_desc { > >> struct virt_dma_desc vdesc; > >> u32

Re: [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator

2018-04-13 Thread Geert Uytterhoeven
Hi Vinod, On Fri, Apr 13, 2018 at 6:02 AM, Vinod Koul wrote: > On Wed, Apr 11, 2018 at 04:44:39PM +0200, Pierre-Yves MORDRET wrote: > >> struct stm32_mdma_desc { >> struct virt_dma_desc vdesc; >> u32 ccr; >> - struct stm32_mdma_hwdesc *hwdesc; >> - dma_addr_t hwdesc_phys; >>

Re: [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator

2018-04-12 Thread Vinod Koul
On Wed, Apr 11, 2018 at 04:44:39PM +0200, Pierre-Yves MORDRET wrote: > struct stm32_mdma_desc { > struct virt_dma_desc vdesc; > u32 ccr; > - struct stm32_mdma_hwdesc *hwdesc; > - dma_addr_t hwdesc_phys; > bool cyclic; > u32 count; > + struct stm32_mdma_desc_nod

[PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator

2018-04-11 Thread Pierre-Yves MORDRET
Only 1 Hw Descriptor is allocated. Loop over required Hw descriptor for proper allocation. Signed-off-by: Pierre-Yves MORDRET --- Version history: v1: * Initial v2: * Fix kbuild warning format: /0x%08x/%pad/ --- --- drivers/dma/stm32-mdma.c | 90 ++