Re: [PATCH v2 2/2] driver core: add helper for deferred probe reason setting

2021-03-23 Thread Ahmad Fatoum
Hello, On 23.03.21 15:07, Greg Kroah-Hartman wrote: > On Fri, Mar 19, 2021 at 12:04:58PM +0100, Ahmad Fatoum wrote: >> We now have three places within the same file doing the same operation >> of freeing this pointer and setting it anew. A helper make this >> arguably easier to read, so add one. >

Re: [PATCH v2 2/2] driver core: add helper for deferred probe reason setting

2021-03-23 Thread Greg Kroah-Hartman
On Fri, Mar 19, 2021 at 12:04:58PM +0100, Ahmad Fatoum wrote: > We now have three places within the same file doing the same operation > of freeing this pointer and setting it anew. A helper make this > arguably easier to read, so add one. > > Signed-off-by: Ahmad Fatoum > --- > v1 -> v2: > - no

Re: [PATCH v2 2/2] driver core: add helper for deferred probe reason setting

2021-03-19 Thread Ahmad Fatoum
Hello Andy, On 19.03.21 13:16, Andy Shevchenko wrote: > On Fri, Mar 19, 2021 at 1:46 PM Ahmad Fatoum wrote: >> On 19.03.21 12:13, Andy Shevchenko wrote: >>> On Fri, Mar 19, 2021 at 1:05 PM Ahmad Fatoum >>> wrote: We now have three places within the same file doing the same operation >

Re: [PATCH v2 2/2] driver core: add helper for deferred probe reason setting

2021-03-19 Thread Andy Shevchenko
On Fri, Mar 19, 2021 at 1:46 PM Ahmad Fatoum wrote: > On 19.03.21 12:13, Andy Shevchenko wrote: > > On Fri, Mar 19, 2021 at 1:05 PM Ahmad Fatoum > > wrote: > >> > >> We now have three places within the same file doing the same operation > >> of freeing this pointer and setting it anew. A helper

Re: [PATCH v2 2/2] driver core: add helper for deferred probe reason setting

2021-03-19 Thread Ahmad Fatoum
Hi, On 19.03.21 12:15, Andy Shevchenko wrote: > On Fri, Mar 19, 2021 at 1:05 PM Ahmad Fatoum wrote: >> >> We now have three places within the same file doing the same operation >> of freeing this pointer and setting it anew. A helper make this >> arguably easier to read, so add one. > >> Signed-

Re: [PATCH v2 2/2] driver core: add helper for deferred probe reason setting

2021-03-19 Thread Ahmad Fatoum
On 19.03.21 12:13, Andy Shevchenko wrote: > On Fri, Mar 19, 2021 at 1:05 PM Ahmad Fatoum wrote: >> >> We now have three places within the same file doing the same operation >> of freeing this pointer and setting it anew. A helper make this > > makes > >> arguably easier to read, so add one. > >

Re: [PATCH v2 2/2] driver core: add helper for deferred probe reason setting

2021-03-19 Thread Andy Shevchenko
On Fri, Mar 19, 2021 at 1:05 PM Ahmad Fatoum wrote: > > We now have three places within the same file doing the same operation > of freeing this pointer and setting it anew. A helper make this > arguably easier to read, so add one. > Signed-off-by: Ahmad Fatoum One thing: Suggested-by? -- Wit

Re: [PATCH v2 2/2] driver core: add helper for deferred probe reason setting

2021-03-19 Thread Andy Shevchenko
On Fri, Mar 19, 2021 at 1:05 PM Ahmad Fatoum wrote: > > We now have three places within the same file doing the same operation > of freeing this pointer and setting it anew. A helper make this makes > arguably easier to read, so add one. FWIW, Reviewed-by: Andy Shevchenko Now I'm wondering wh

[PATCH v2 2/2] driver core: add helper for deferred probe reason setting

2021-03-19 Thread Ahmad Fatoum
We now have three places within the same file doing the same operation of freeing this pointer and setting it anew. A helper make this arguably easier to read, so add one. Signed-off-by: Ahmad Fatoum --- v1 -> v2: - no change --- drivers/base/dd.c | 17 +++-- 1 file changed, 11 inse