Re: [PATCH v2 2/2] i2c: eg20t: use generic power management

2020-08-25 Thread Bjorn Helgaas
On Tue, Aug 25, 2020 at 11:53:42AM +0200, Jean Delvare wrote: > Hi Bjorn, Vaibhav, > > On Fri, 07 Aug 2020 15:23:21 -0500, Bjorn Helgaas wrote: > > Also, i801_suspend() looks suspicious because it writes SMBHSTCFG, but > > I don't see anything corresponding in i801_resume(). > > You're right,

Re: [PATCH v2 2/2] i2c: eg20t: use generic power management

2020-08-25 Thread Jean Delvare
Hi Bjorn, Vaibhav, On Fri, 07 Aug 2020 15:23:21 -0500, Bjorn Helgaas wrote: > Also, i801_suspend() looks suspicious because it writes SMBHSTCFG, but > I don't see anything corresponding in i801_resume(). You're right, it's buggy. Volker Rümelin's patch at:

Re: [PATCH v2 2/2] i2c: eg20t: use generic power management

2020-08-10 Thread Wolfram Sang
On Thu, Aug 06, 2020 at 01:06:16AM +0530, Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. > > Switch to generic power

Re: [PATCH v2 2/2] i2c: eg20t: use generic power management

2020-08-10 Thread Vaibhav Gupta
On Fri, Aug 07, 2020 at 03:23:21PM -0500, Bjorn Helgaas wrote: > [+cc Jean for i801 question below] > > On Thu, Aug 06, 2020 at 01:06:16AM +0530, Vaibhav Gupta wrote: > > Drivers using legacy power management .suspen()/.resume() callbacks > > have to manage PCI states and device's PM states

Re: [PATCH v2 2/2] i2c: eg20t: use generic power management

2020-08-07 Thread Bjorn Helgaas
[+cc Jean for i801 question below] On Thu, Aug 06, 2020 at 01:06:16AM +0530, Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers.

[PATCH v2 2/2] i2c: eg20t: use generic power management

2020-08-05 Thread Vaibhav Gupta
Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the