Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-15 Thread Nikolaus Schulz
On Sat, Dec 13, 2014 at 12:29:57PM +0100, Lars-Peter Clausen wrote: > On 11/24/2014 08:50 PM, Nikolaus Schulz wrote: > [...] > >+const struct iio_chan_spec dac8554_channels[] = { > > static > > [...] > >+ret = of_property_read_u32(spi->dev.of_node, "address", ); > > This should probably

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-15 Thread Nikolaus Schulz
On Sat, Dec 13, 2014 at 12:18:50PM +0100, Hartmut Knaack wrote: > Nikolaus Schulz schrieb am 12.12.2014 um 16:58: > > On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: > >> Nikolaus Schulz schrieb am 24.11.2014 um 20:50: > >>> The TI DAC8554 is a quad-channel Digital-to-Analog

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-15 Thread Nikolaus Schulz
On Sat, Dec 13, 2014 at 12:18:50PM +0100, Hartmut Knaack wrote: Nikolaus Schulz schrieb am 12.12.2014 um 16:58: On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: Nikolaus Schulz schrieb am 24.11.2014 um 20:50: The TI DAC8554 is a quad-channel Digital-to-Analog Converter with

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-15 Thread Nikolaus Schulz
On Sat, Dec 13, 2014 at 12:29:57PM +0100, Lars-Peter Clausen wrote: On 11/24/2014 08:50 PM, Nikolaus Schulz wrote: [...] +const struct iio_chan_spec dac8554_channels[] = { static [...] +ret = of_property_read_u32(spi-dev.of_node, address, addr); This should probably have vendor

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Lars-Peter Clausen
On 12/06/2014 12:36 PM, Hartmut Knaack wrote: [...] +static int dac8554_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, + int *val2, + long m) Commonly, m

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Lars-Peter Clausen
On 11/24/2014 08:50 PM, Nikolaus Schulz wrote: [...] +const struct iio_chan_spec dac8554_channels[] = { static [...] + ret = of_property_read_u32(spi->dev.of_node, "address", ); This should probably have vendor prefix. + if (ret || addr < 0 || addr > 2) { +

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Lars-Peter Clausen
On 12/13/2014 12:18 PM, Hartmut Knaack wrote: [...] According to your DT bindings, the regulator from property "vref-supply" should be used. This is missing here. Uhm, it's right below, no? Looking into your DT bindings patch (which unfortunately didn't make it into our list), you specify

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Hartmut Knaack
Hartmut Knaack schrieb am 13.12.2014 um 12:18: > Nikolaus Schulz schrieb am 12.12.2014 um 16:58: >> On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: >>> Nikolaus Schulz schrieb am 24.11.2014 um 20:50: The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Hartmut Knaack
Nikolaus Schulz schrieb am 12.12.2014 um 16:58: > On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: >> Nikolaus Schulz schrieb am 24.11.2014 um 20:50: >>> The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI >>> interface. >>> >>> Changes in v2: >>> * Use DMA-safe

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Hartmut Knaack
Nikolaus Schulz schrieb am 12.12.2014 um 16:58: On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: Nikolaus Schulz schrieb am 24.11.2014 um 20:50: The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI interface. Changes in v2: * Use DMA-safe buffer for SPI

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Hartmut Knaack
Hartmut Knaack schrieb am 13.12.2014 um 12:18: Nikolaus Schulz schrieb am 12.12.2014 um 16:58: On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: Nikolaus Schulz schrieb am 24.11.2014 um 20:50: The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI interface.

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Lars-Peter Clausen
On 12/13/2014 12:18 PM, Hartmut Knaack wrote: [...] According to your DT bindings, the regulator from property vref-supply should be used. This is missing here. Uhm, it's right below, no? Looking into your DT bindings patch (which unfortunately didn't make it into our list), you specify

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Lars-Peter Clausen
On 11/24/2014 08:50 PM, Nikolaus Schulz wrote: [...] +const struct iio_chan_spec dac8554_channels[] = { static [...] + ret = of_property_read_u32(spi-dev.of_node, address, addr); This should probably have vendor prefix. + if (ret || addr 0 || addr 2) { +

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-13 Thread Lars-Peter Clausen
On 12/06/2014 12:36 PM, Hartmut Knaack wrote: [...] +static int dac8554_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, + int *val2, + long m) Commonly, m

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-12 Thread Jonathan Cameron
On 12/12/14 15:58, Nikolaus Schulz wrote: > On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: >> Nikolaus Schulz schrieb am 24.11.2014 um 20:50: >>> The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI >>> interface. >>> >>> Changes in v2: >>> * Use DMA-safe

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-12 Thread Nikolaus Schulz
On Fri, Dec 12, 2014 at 11:57:08AM +, Jonathan Cameron wrote: > On 06/12/14 11:36, Hartmut Knaack wrote: > > Nikolaus Schulz schrieb am 24.11.2014 um 20:50: > >> The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI > >> interface. > >> > >> Changes in v2: > >> * Use

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-12 Thread Nikolaus Schulz
On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: > Nikolaus Schulz schrieb am 24.11.2014 um 20:50: > > The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI > > interface. > > > > Changes in v2: > > * Use DMA-safe buffer for SPI transfer > > * Normalize

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-12 Thread Jonathan Cameron
On 06/12/14 11:36, Hartmut Knaack wrote: > Nikolaus Schulz schrieb am 24.11.2014 um 20:50: >> The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI >> interface. >> >> Changes in v2: >> * Use DMA-safe buffer for SPI transfer >> * Normalize powerdown_mode name "hi-z" to

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-12 Thread Jonathan Cameron
On 06/12/14 11:36, Hartmut Knaack wrote: Nikolaus Schulz schrieb am 24.11.2014 um 20:50: The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI interface. Changes in v2: * Use DMA-safe buffer for SPI transfer * Normalize powerdown_mode name hi-z to three_state as per

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-12 Thread Nikolaus Schulz
On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: Nikolaus Schulz schrieb am 24.11.2014 um 20:50: The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI interface. Changes in v2: * Use DMA-safe buffer for SPI transfer * Normalize powerdown_mode name

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-12 Thread Nikolaus Schulz
On Fri, Dec 12, 2014 at 11:57:08AM +, Jonathan Cameron wrote: On 06/12/14 11:36, Hartmut Knaack wrote: Nikolaus Schulz schrieb am 24.11.2014 um 20:50: The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI interface. Changes in v2: * Use DMA-safe buffer for SPI

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-12 Thread Jonathan Cameron
On 12/12/14 15:58, Nikolaus Schulz wrote: On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote: Nikolaus Schulz schrieb am 24.11.2014 um 20:50: The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI interface. Changes in v2: * Use DMA-safe buffer for SPI transfer

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-06 Thread Hartmut Knaack
Nikolaus Schulz schrieb am 24.11.2014 um 20:50: > The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI > interface. > > Changes in v2: > * Use DMA-safe buffer for SPI transfer > * Normalize powerdown_mode name "hi-z" to "three_state" as per > ABI/testing/sysfs-bus-iio > *

Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-12-06 Thread Hartmut Knaack
Nikolaus Schulz schrieb am 24.11.2014 um 20:50: The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI interface. Changes in v2: * Use DMA-safe buffer for SPI transfer * Normalize powerdown_mode name hi-z to three_state as per ABI/testing/sysfs-bus-iio * Register

[PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-11-24 Thread Nikolaus Schulz
The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI interface. Changes in v2: * Use DMA-safe buffer for SPI transfer * Normalize powerdown_mode name "hi-z" to "three_state" as per ABI/testing/sysfs-bus-iio * Register device late in probe function * Avoid powerdown broadcast

[PATCH v2 2/2] iio: add driver for the TI DAC8554

2014-11-24 Thread Nikolaus Schulz
The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI interface. Changes in v2: * Use DMA-safe buffer for SPI transfer * Normalize powerdown_mode name hi-z to three_state as per ABI/testing/sysfs-bus-iio * Register device late in probe function * Avoid powerdown broadcast