[PATCH v2 2/2] iio: light: as73211: New driver

2020-07-27 Thread Christian Eggers
Support for AMS AS73211 JENCOLOR(R) Digital XYZ Sensor. This driver has no built-in trigger. In order for making triggered measurements, an external (software) trigger driver like iio-trig-hrtimer or iio-trig-sysfs is required. The sensor supports single and continuous measurement modes. The latt

Re: [PATCH v2 2/2] iio: light: as73211: New driver

2020-07-30 Thread Christian Eggers
Hi Andy, thanks for the extensive review. Almost all of you comments will be integrated into v3. On Tuesday, 28 July 2020, 20:00:31 CEST, Andy Shevchenko wrote: > On Tue, Jul 28, 2020 at 9:32 AM Christian Eggers wrote: > > + if (data->client->irq) > > + init_completion(&da

Re: [PATCH v2 2/2] iio: light: as73211: New driver

2020-07-30 Thread Christian Eggers
Hi Jonathan. got your review nearly simultaneous with Andy's. There are many overlaps between both. Most is already integrated, below I left only the open points. On Tuesday, 28 July 2020, 20:01:14 CEST, Jonathan Cameron wrote: > Hi Christian, > > I took a fairly quick look. Not divided into the

Re: [PATCH v2 2/2] iio: light: as73211: New driver

2020-08-01 Thread Jonathan Cameron
On Thu, 30 Jul 2020 12:18:56 +0200 Christian Eggers wrote: > Hi Jonathan. > > got your review nearly simultaneous with Andy's. There are many overlaps > between both. Most is already integrated, below I left only the open points. > > On Tuesday, 28 July 2020, 20:01:14 CEST, Jonathan Cameron wro

Re: [PATCH v2 2/2] iio: light: as73211: New driver

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 9:32 AM Christian Eggers wrote: > > Support for AMS AS73211 JENCOLOR(R) Digital XYZ Sensor. > > This driver has no built-in trigger. In order for making triggered > measurements, an external (software) trigger driver like > iio-trig-hrtimer or iio-trig-sysfs is required. >

Re: [PATCH v2 2/2] iio: light: as73211: New driver

2020-07-28 Thread Jonathan Cameron
On Tue, 28 Jul 2020 08:28:31 +0200 Christian Eggers wrote: > Support for AMS AS73211 JENCOLOR(R) Digital XYZ Sensor. > > This driver has no built-in trigger. In order for making triggered > measurements, an external (software) trigger driver like > iio-trig-hrtimer or iio-trig-sysfs is required.