On Thu, 2019-06-06 at 08:05 +0100, Marc Zyngier wrote:
>
> > I disagree Marc. This is a rather bad error which indicates that the
> > device-tree is probably incorrect (or the HW was wired in a way that
> > cannot work).
>
> But surely that's something you'll spot pretty quickly.
Not really. A l
On 6/5/2019 6:12 PM, Marc Zyngier wrote:
On 05/06/2019 15:38, Shenhar, Talel wrote:
FIC only support two sensing modes, rising-edge and level.
Yes, I can tell. Yet, this code will let EDGE_BOTH pass through, even if
it cannot handle it.
Will handle on v4
Indeed we use interrupt specifier t
On Wed, 05 Jun 2019 23:02:13 +0100,
Benjamin Herrenschmidt wrote:
>
> On Wed, 2019-06-05 at 13:22 +0100, Marc Zyngier wrote:
> >
> > > + * This is generally fixed depending on what pieces of HW it's wired up
> > > + * to.
> > > + *
> > > + * We configure it based on the sensitivity of the fi
On Wed, 05 Jun 2019 23:06:05 +0100,
Benjamin Herrenschmidt wrote:
>
> On Wed, 2019-06-05 at 16:12 +0100, Marc Zyngier wrote:
> > > Those error messages are control path messages. if we return the same
> > > error value from here and from the previous error, how can we
> > > differentiate betwee
On Wed, 2019-06-05 at 16:12 +0100, Marc Zyngier wrote:
> > Those error messages are control path messages. if we return the same
> > error value from here and from the previous error, how can we
> > differentiate between the two error cases by looking at the log?
> >
> > Having informative print
On Wed, 2019-06-05 at 13:22 +0100, Marc Zyngier wrote:
>
> > +* This is generally fixed depending on what pieces of HW it's wired up
> > +* to.
> > +*
> > +* We configure it based on the sensitivity of the first source
> > +* being setup, and reject any subsequent attempt at co
On Wed, Jun 05, 2019 at 05:51:08PM +0300, Shenhar, Talel wrote:
>
> On 6/5/2019 3:50 PM, Greg KH wrote:
> > On Wed, Jun 05, 2019 at 01:52:01PM +0300, Talel Shenhar wrote:
> > > --- /dev/null
> > > +++ b/drivers/irqchip/irq-al-fic.c
> > > @@ -0,0 +1,289 @@
> > > +// SPDX-License-Identifier: GPL-2.0
On 05/06/2019 15:38, Shenhar, Talel wrote:
> Thanks, will publish the fixes on v3.
>
> On 6/5/2019 3:22 PM, Marc Zyngier wrote:
>> Talel,
>>
>> On 05/06/2019 11:52, Talel Shenhar wrote:
>>> The Amazon's Annapurna Labs Fabric Interrupt Controller has 32 inputs
>>> lines. A FIC (Fabric Interrupt Con
On Wed, 2019-06-05 at 14:50 +0200, Greg KH wrote:
> On Wed, Jun 05, 2019 at 01:52:01PM +0300, Talel Shenhar wrote:
> > --- /dev/null
> > +++ b/drivers/irqchip/irq-al-fic.c
> > @@ -0,0 +1,289 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/**
>
> No need for kernel-doc format style here.
>
> > +
On 6/5/2019 3:50 PM, Greg KH wrote:
On Wed, Jun 05, 2019 at 01:52:01PM +0300, Talel Shenhar wrote:
--- /dev/null
+++ b/drivers/irqchip/irq-al-fic.c
@@ -0,0 +1,289 @@
+// SPDX-License-Identifier: GPL-2.0
+/**
No need for kernel-doc format style here.
done
+ * Copyright 2019 Amazon.com, Inc
Thanks, will publish the fixes on v3.
On 6/5/2019 3:22 PM, Marc Zyngier wrote:
Talel,
On 05/06/2019 11:52, Talel Shenhar wrote:
The Amazon's Annapurna Labs Fabric Interrupt Controller has 32 inputs
lines. A FIC (Fabric Interrupt Controller) may be cascaded into another FIC
Really? :-(
Casca
On Wed, Jun 05, 2019 at 01:52:01PM +0300, Talel Shenhar wrote:
> --- /dev/null
> +++ b/drivers/irqchip/irq-al-fic.c
> @@ -0,0 +1,289 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/**
No need for kernel-doc format style here.
> + * Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reser
Talel,
On 05/06/2019 11:52, Talel Shenhar wrote:
> The Amazon's Annapurna Labs Fabric Interrupt Controller has 32 inputs
> lines. A FIC (Fabric Interrupt Controller) may be cascaded into another FIC
Really? :-(
> or directly to the main CPU Interrupt Controller (e.g. GIC).
>
> Signed-off-by: Ta
The Amazon's Annapurna Labs Fabric Interrupt Controller has 32 inputs
lines. A FIC (Fabric Interrupt Controller) may be cascaded into another FIC
or directly to the main CPU Interrupt Controller (e.g. GIC).
Signed-off-by: Talel Shenhar
---
MAINTAINERS | 6 +
drivers/irqchip/Kc
14 matches
Mail list logo
