Re: [PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-06-21 Thread Baolin Wang
Hi Jacek and Bjorn, > OK, I've revised the discussion under Qualcomm LPG patch set and > it seems that we have almost ready solution in [0], except the > pattern_repeat file you mention in [1]. So probably Baolin could > address your remarks from [1] and add pattern_repeat file to the > patch that

Re: [PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-12 Thread Baolin Wang
Hi Jacek and Pavel, On 13 May 2018 at 04:44, Jacek Anaszewski wrote: > Hi Pavel, > > > On 05/12/2018 10:35 AM, Pavel Machek wrote: >> >> Hi! >> > I disagree here. We already had the same discussion at the occasion > of the patch [0] and it turned out to be a dead-end [1]. Now we have

Re: [PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-12 Thread Jacek Anaszewski
Hi Pavel, On 05/12/2018 10:35 AM, Pavel Machek wrote: Hi! I disagree here. We already had the same discussion at the occasion of the patch [0] and it turned out to be a dead-end [1]. Now we have neither the driver nor the generic pattern interface. We also already have some older LED class dr

Re: [PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-12 Thread Pavel Machek
Hi! > >>I disagree here. We already had the same discussion at the occasion > >>of the patch [0] and it turned out to be a dead-end [1]. Now we have > >>neither the driver nor the generic pattern interface. > >> > >>We also already have some older LED class drivers that implement custom > >>patter

Re: [PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-10 Thread Jacek Anaszewski
Hi Pavel, On 05/10/2018 01:37 PM, Pavel Machek wrote: Hi! This patch adds Spreadtrum SC27xx PMIC series breathing light controller driver, which can support 3 LEDs. Each LED can work at normal PWM mode and breathing mode. diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx b

Re: [PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-10 Thread Pavel Machek
Hi! > >>This patch adds Spreadtrum SC27xx PMIC series breathing light controller > >>driver, which can support 3 LEDs. Each LED can work at normal PWM mode > >>and breathing mode. > >> > >>diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx > >>b/Documentation/ABI/testing/sysfs-c

Re: [PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-09 Thread Baolin Wang
Hi Pavel, On 9 May 2018 at 22:25, Pavel Machek wrote: > On Tue 2018-05-08 13:39:45, Baolin Wang wrote: >> From: Xiaotong Lu >> >> This patch adds Spreadtrum SC27xx PMIC series breathing light controller >> driver, which can support 3 LEDs. Each LED can work at normal PWM mode >> and breathing mo

Re: [PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-09 Thread Jacek Anaszewski
Hi, On 05/09/2018 04:25 PM, Pavel Machek wrote: On Tue 2018-05-08 13:39:45, Baolin Wang wrote: From: Xiaotong Lu This patch adds Spreadtrum SC27xx PMIC series breathing light controller driver, which can support 3 LEDs. Each LED can work at normal PWM mode and breathing mode. diff --git a/Do

Re: [PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-09 Thread Pavel Machek
On Tue 2018-05-08 13:39:45, Baolin Wang wrote: > From: Xiaotong Lu > > This patch adds Spreadtrum SC27xx PMIC series breathing light controller > driver, which can support 3 LEDs. Each LED can work at normal PWM mode > and breathing mode. > > diff --git a/Documentation/ABI/testing/sysfs-class-le

Re: [PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-08 Thread Baolin Wang
Hi Jacek, On 9 May 2018 at 04:54, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the updated version. > > I have few notes below, please take a look. > > > On 05/08/2018 07:39 AM, Baolin Wang wrote: >> >> From: Xiaotong Lu >> >> This patch adds Spreadtrum SC27xx PMIC series breathing lig

Re: [PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-08 Thread Jacek Anaszewski
Hi Baolin, Thank you for the updated version. I have few notes below, please take a look. On 05/08/2018 07:39 AM, Baolin Wang wrote: From: Xiaotong Lu This patch adds Spreadtrum SC27xx PMIC series breathing light controller driver, which can support 3 LEDs. Each LED can work at normal PWM mo

[PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-07 Thread Baolin Wang
From: Xiaotong Lu This patch adds Spreadtrum SC27xx PMIC series breathing light controller driver, which can support 3 LEDs. Each LED can work at normal PWM mode and breathing mode. Signed-off-by: Xiaotong Lu Signed-off-by: Baolin Wang --- Changes since v1: - Add ABI documentation. - Add mut