Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-29 Thread Jacek Anaszewski
Dan, On 1/29/19 9:26 PM, Dan Murphy wrote: Jacek On 1/29/19 2:19 PM, Jacek Anaszewski wrote: Hi Dan, On 1/29/19 2:56 PM, Dan Murphy wrote: Jacek On 1/24/19 3:55 PM, Jacek Anaszewski wrote: Dan On 1/24/19 10:00 PM, Dan Murphy wrote: Jacek On 1/23/19 3:52 PM, Jacek Anaszewski wrote:

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-29 Thread Dan Murphy
Pavel On 1/29/19 3:45 PM, Pavel Machek wrote: > Hi! > > Could you, trim the parts of email you do not need in the reply? This > is quite annoying to follow: > Agreed. > On Tue 2019-01-29 14:26:20, Dan Murphy wrote: >> Jacek >> >> On 1/29/19 2:19 PM, Jacek Anaszewski wrote: >>> Hi Dan, >>> >>>

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-29 Thread Pavel Machek
Hi! Could you, trim the parts of email you do not need in the reply? This is quite annoying to follow: On Tue 2019-01-29 14:26:20, Dan Murphy wrote: > Jacek > > On 1/29/19 2:19 PM, Jacek Anaszewski wrote: > > Hi Dan, > > > > On 1/29/19 2:56 PM, Dan Murphy wrote: > >> Jacek > >> > >> On 1/24/19

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-29 Thread Dan Murphy
Jacek On 1/29/19 2:19 PM, Jacek Anaszewski wrote: > Hi Dan, > > On 1/29/19 2:56 PM, Dan Murphy wrote: >> Jacek >> >> On 1/24/19 3:55 PM, Jacek Anaszewski wrote: >>> Dan >>> >>> On 1/24/19 10:00 PM, Dan Murphy wrote: Jacek On 1/23/19 3:52 PM, Jacek Anaszewski wrote: > Dan,

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-29 Thread Jacek Anaszewski
Hi Dan, On 1/29/19 2:56 PM, Dan Murphy wrote: Jacek On 1/24/19 3:55 PM, Jacek Anaszewski wrote: Dan On 1/24/19 10:00 PM, Dan Murphy wrote: Jacek On 1/23/19 3:52 PM, Jacek Anaszewski wrote: Dan, On 1/22/19 11:44 PM, Dan Murphy wrote: Jacek On 1/22/19 3:39 PM, Jacek Anaszewski wrote: Hi

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-29 Thread Dan Murphy
Jacek On 1/24/19 3:55 PM, Jacek Anaszewski wrote: > Dan > > On 1/24/19 10:00 PM, Dan Murphy wrote: >> Jacek >> >> On 1/23/19 3:52 PM, Jacek Anaszewski wrote: >>> Dan, >>> >>> On 1/22/19 11:44 PM, Dan Murphy wrote: Jacek On 1/22/19 3:39 PM, Jacek Anaszewski wrote: > Hi all,

Re: RGB LED class Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-28 Thread Pavel Machek
Hi! > >>What algorithm would be used for mapping brightness levels to RGB values > >>in case of devices without hardware support for that? > > > >Output power = brightness / max_brightness * pwm_channel[x]. > > IIUC you mean it as a formula for calculating r,g,b, values? > I.e., on brightness

Re: RGB LED class Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-28 Thread Pavel Machek
Hi! > > First, I think we want to decide if RGB LED should be presented as > > 3 LEDs or as 1 LED... and what to do with existing RGB leds being > > presented as 3 LEDs. > > What do we do with RGBW drivers? Like the LP5562. RGB can be grouped as a > single > LED but does the white LED get

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-24 Thread Jacek Anaszewski
Dan On 1/24/19 10:00 PM, Dan Murphy wrote: Jacek On 1/23/19 3:52 PM, Jacek Anaszewski wrote: Dan, On 1/22/19 11:44 PM, Dan Murphy wrote: Jacek On 1/22/19 3:39 PM, Jacek Anaszewski wrote: Hi all, On 1/20/19 7:42 AM, Vesa Jääskeläinen wrote: Hi Dan, On 18/01/2019 15.58, Dan Murphy wrote:

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-24 Thread Jacek Anaszewski
Dan, On 1/24/19 9:32 PM, Dan Murphy wrote: Jacek Replying to code comments. On 1/15/19 3:47 PM, Jacek Anaszewski wrote: Hi Da, Thank you for the v2. I will probably submit v3 outside the realm of the multi color framework. We can always convert as Pavel pointed out. I have some remarks

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-24 Thread Dan Murphy
Jacek On 1/23/19 3:52 PM, Jacek Anaszewski wrote: > Dan, > > On 1/22/19 11:44 PM, Dan Murphy wrote: >> Jacek >> >> On 1/22/19 3:39 PM, Jacek Anaszewski wrote: >>> Hi all, >>> >>> On 1/20/19 7:42 AM, Vesa Jääskeläinen wrote: Hi Dan, On 18/01/2019 15.58, Dan Murphy wrote: >

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-24 Thread Dan Murphy
Jacek Replying to code comments. On 1/15/19 3:47 PM, Jacek Anaszewski wrote: > Hi Da, > > Thank you for the v2. > I will probably submit v3 outside the realm of the multi color framework. We can always convert as Pavel pointed out. > I have some remarks below. > > On 1/14/19 10:17 PM, Dan

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-23 Thread Jacek Anaszewski
Dan, On 1/22/19 11:44 PM, Dan Murphy wrote: Jacek On 1/22/19 3:39 PM, Jacek Anaszewski wrote: Hi all, On 1/20/19 7:42 AM, Vesa Jääskeläinen wrote: Hi Dan, On 18/01/2019 15.58, Dan Murphy wrote: Jacek On 1/18/19 7:45 AM, Dan Murphy wrote: Jacek On 1/17/19 3:10 PM, Jacek Anaszewski

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-22 Thread Dan Murphy
Jacek On 1/22/19 3:39 PM, Jacek Anaszewski wrote: > Hi all, > > On 1/20/19 7:42 AM, Vesa Jääskeläinen wrote: >> Hi Dan, >> >> On 18/01/2019 15.58, Dan Murphy wrote: >>> Jacek >>> >>> On 1/18/19 7:45 AM, Dan Murphy wrote: Jacek On 1/17/19 3:10 PM, Jacek Anaszewski wrote: > Hi

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-22 Thread Jacek Anaszewski
Hi all, On 1/20/19 7:42 AM, Vesa Jääskeläinen wrote: Hi Dan, On 18/01/2019 15.58, Dan Murphy wrote: Jacek On 1/18/19 7:45 AM, Dan Murphy wrote: Jacek On 1/17/19 3:10 PM, Jacek Anaszewski wrote: Hi Dan, On 1/16/19 7:41 PM, Dan Murphy wrote: Hello On 1/16/19 4:55 AM, Pavel Machek wrote:

Re: RGB LED class Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-21 Thread Jacek Anaszewski
On 1/20/19 4:30 PM, Jacek Anaszewski wrote: On 1/19/19 10:36 PM, Pavel Machek wrote: Hi! [...] I want to make sure userspace understands this has linear relation to output power. I'd like to avoid mentioning color because there power output is not linear with "RGB" s/pwm/color/

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-21 Thread Vesa Jääskeläinen
Hi Dan, On 21/01/2019 15.27, Dan Murphy wrote: Vesa On 1/19/19 1:11 PM, Vesa Jääskeläinen wrote: Hi Jacek et al, On 17/01/2019 23.08, Jacek Anaszewski wrote: On 1/16/19 11:55 AM, Pavel Machek wrote: Hi! On 1/15/19 4:22 PM, Pavel Machek wrote: Hi! +The 24-bit RGB value passed in

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-21 Thread Dan Murphy
Vesa On 1/19/19 1:11 PM, Vesa Jääskeläinen wrote: > Hi Jacek et al, > > On 17/01/2019 23.08, Jacek Anaszewski wrote: >> On 1/16/19 11:55 AM, Pavel Machek wrote: >>> Hi! >>> On 1/15/19 4:22 PM, Pavel Machek wrote: > Hi! > >>> +The 24-bit RGB value passed in follows the pattern

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-20 Thread Jacek Anaszewski
Dan, On 1/18/19 2:45 PM, Dan Murphy wrote: Jacek On 1/17/19 3:10 PM, Jacek Anaszewski wrote: Hi Dan, On 1/16/19 7:41 PM, Dan Murphy wrote: Hello On 1/16/19 4:55 AM, Pavel Machek wrote: Hi! On 1/15/19 4:22 PM, Pavel Machek wrote: Hi! +The 24-bit RGB value passed in follows the pattern

Re: RGB LED class Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-20 Thread Jacek Anaszewski
On 1/19/19 10:36 PM, Pavel Machek wrote: Hi! First, I think we want to decide if RGB LED should be presented as 3 LEDs or as 1 LED... and what to do with existing RGB leds being presented as 3 LEDs. I don't think we want to support both RGB and HSV in the kernel. It is math, and not a nice

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-19 Thread Vesa Jääskeläinen
Hi Pavel, On 19/01/2019 23.46, Pavel Machek wrote: Hi! Moreover, I think that RGB LED class with configurable brightness-model, and with possible color range adjustments via icc-profiles or something similar, is the best solution that has been proposed so far. It is just flexible. I'd like

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-19 Thread Vesa Jääskeläinen
Hi Dan, On 18/01/2019 15.58, Dan Murphy wrote: Jacek On 1/18/19 7:45 AM, Dan Murphy wrote: Jacek On 1/17/19 3:10 PM, Jacek Anaszewski wrote: Hi Dan, On 1/16/19 7:41 PM, Dan Murphy wrote: Hello On 1/16/19 4:55 AM, Pavel Machek wrote: Hi! On 1/15/19 4:22 PM, Pavel Machek wrote: Hi!

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-19 Thread Vesa Jääskeläinen
Hi Pavel, On 19/01/2019 23.46, Pavel Machek wrote: Hi! Moreover, I think that RGB LED class with configurable brightness-model, and with possible color range adjustments via icc-profiles or something similar, is the best solution that has been proposed so far. It is just flexible. I'd like

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-19 Thread Pavel Machek
Hi! > >Moreover, I think that RGB LED class with configurable > >brightness-model, and with possible color range adjustments via > >icc-profiles or something similar, is the best solution that has been > >proposed so far. It is just flexible. > > > >I'd like to capitalize on the ideas shared in

Re: RGB LED class Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-19 Thread Pavel Machek
Hi! > >First, I think we want to decide if RGB LED should be presented as > >3 LEDs or as 1 LED... and what to do with existing RGB leds being > >presented as 3 LEDs. > > > >I don't think we want to support both RGB and HSV in the kernel. It is > >math, and not a nice one. > > > >Yes, both have

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-19 Thread Vesa Jääskeläinen
Hi Jacek et al, On 17/01/2019 23.08, Jacek Anaszewski wrote: On 1/16/19 11:55 AM, Pavel Machek wrote: Hi! On 1/15/19 4:22 PM, Pavel Machek wrote: Hi! +The 24-bit RGB value passed in follows the pattern 0xXXRRGGBB +XX - Do not care ignored by the driver +RR - is the 8 bit Red LED value +GG

Re: RGB LED class Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-18 Thread Jacek Anaszewski
Hi Pavel, On 1/18/19 1:02 AM, Pavel Machek wrote: Hi! I am willing to work with you on the HSV and adapting the LP50xx part to this framework. Or any RGB framework for that matter. I still don't agree with the kernel needing to declare colors maybe color capabilities but not specific

Re: RGB LED class Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-18 Thread Dan Murphy
Hello On 1/17/19 6:02 PM, Pavel Machek wrote: > Hi! > > >>> I am willing to work with you on the HSV and adapting the LP50xx part to >>> this framework. >>> Or any RGB framework for that matter. I still don't agree with the kernel >>> needing to declare colors >>> maybe color capabilities

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-18 Thread Dan Murphy
Jacek On 1/18/19 7:45 AM, Dan Murphy wrote: > Jacek > > On 1/17/19 3:10 PM, Jacek Anaszewski wrote: >> Hi Dan, >> >> On 1/16/19 7:41 PM, Dan Murphy wrote: >>> Hello >>> >>> On 1/16/19 4:55 AM, Pavel Machek wrote: Hi! > On 1/15/19 4:22 PM, Pavel Machek wrote: >> Hi! >>

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-18 Thread Dan Murphy
Jacek On 1/17/19 3:10 PM, Jacek Anaszewski wrote: > Hi Dan, > > On 1/16/19 7:41 PM, Dan Murphy wrote: >> Hello >> >> On 1/16/19 4:55 AM, Pavel Machek wrote: >>> Hi! >>> On 1/15/19 4:22 PM, Pavel Machek wrote: > Hi! > >>> +The 24-bit RGB value passed in follows the pattern

RGB LED class Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-17 Thread Pavel Machek
Hi! > >I am willing to work with you on the HSV and adapting the LP50xx part to > >this framework. > >Or any RGB framework for that matter. I still don't agree with the kernel > >needing to declare colors > > maybe color capabilities but not specific colors. > > Dan, if you have a bandwidth

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-17 Thread Jacek Anaszewski
Hi Dan, On 1/16/19 7:41 PM, Dan Murphy wrote: Hello On 1/16/19 4:55 AM, Pavel Machek wrote: Hi! On 1/15/19 4:22 PM, Pavel Machek wrote: Hi! +The 24-bit RGB value passed in follows the pattern 0xXXRRGGBB +XX - Do not care ignored by the driver +RR - is the 8 bit Red LED value +GG - is the

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-17 Thread Jacek Anaszewski
On 1/16/19 11:55 AM, Pavel Machek wrote: Hi! On 1/15/19 4:22 PM, Pavel Machek wrote: Hi! +The 24-bit RGB value passed in follows the pattern 0xXXRRGGBB +XX - Do not care ignored by the driver +RR - is the 8 bit Red LED value +GG - is the 8 bit Green LED value +BB - is the 8 bit Blue LED

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-17 Thread Dan Murphy
Hello On 1/17/19 4:06 AM, Pavel Machek wrote: > Hi! > > You know what? First, submit driver with similar functionality to > existing RGB drivers, using same interface existing drivers are > using. When that is accepted, we can talk about extending > kernel<->user interfaces.

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-17 Thread Pavel Machek
Hi! > >>> You know what? First, submit driver with similar functionality to > >>> existing RGB drivers, using same interface existing drivers are > >>> using. When that is accepted, we can talk about extending > >>> kernel<->user interfaces. > >>> > >> > >> I could do that but then there is no

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-16 Thread Dan Murphy
Hello On 1/16/19 4:04 PM, Pavel Machek wrote: > Hi! > > ..snip. Let me read it and reply when I have a time. > >>> You know what? First, submit driver with similar functionality to >>> existing RGB drivers, using same interface existing drivers are >>> using. When that is accepted, we can talk

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-16 Thread Pavel Machek
Hi! ..snip. Let me read it and reply when I have a time. > > You know what? First, submit driver with similar functionality to > > existing RGB drivers, using same interface existing drivers are > > using. When that is accepted, we can talk about extending > > kernel<->user interfaces. > > > >

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-16 Thread Dan Murphy
Hello On 1/16/19 4:55 AM, Pavel Machek wrote: > Hi! > >> On 1/15/19 4:22 PM, Pavel Machek wrote: >>> Hi! >>> > +The 24-bit RGB value passed in follows the pattern 0xXXRRGGBB > +XX - Do not care ignored by the driver > +RR - is the 8 bit Red LED value > +GG - is the 8 bit Green

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-16 Thread Pavel Machek
Hi! > On 1/15/19 4:22 PM, Pavel Machek wrote: > > Hi! > > > >>> +The 24-bit RGB value passed in follows the pattern 0xXXRRGGBB > >>> +XX - Do not care ignored by the driver > >>> +RR - is the 8 bit Red LED value > >>> +GG - is the 8 bit Green LED value > >>> +BB - is the 8 bit Blue LED value >

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-15 Thread Dan Murphy
Hello Pavel Thanks for the review it is always good to have your comments. On 1/15/19 4:22 PM, Pavel Machek wrote: > Hi! > >>> +The 24-bit RGB value passed in follows the pattern 0xXXRRGGBB >>> +XX - Do not care ignored by the driver >>> +RR - is the 8 bit Red LED value >>> +GG - is the 8 bit

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-15 Thread Pavel Machek
Hi! > >+The 24-bit RGB value passed in follows the pattern 0xXXRRGGBB > >+XX - Do not care ignored by the driver > >+RR - is the 8 bit Red LED value > >+GG - is the 8 bit Green LED value > >+BB - is the 8 bit Blue LED value > >+ > >+Example: > >+LED module output 4 of the LP5024 will be a yellow

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-15 Thread Jacek Anaszewski
Hi Da, Thank you for the v2. I have some remarks below. On 1/14/19 10:17 PM, Dan Murphy wrote: Introduce the LP5036/30/24/18 RGB LED driver. The difference in these parts are the number of LED outputs where the: LP5036 can control 36 LEDs LP5030 can control 30 LEDs LP5024 can control 24 LEDs

[PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-14 Thread Dan Murphy
Introduce the LP5036/30/24/18 RGB LED driver. The difference in these parts are the number of LED outputs where the: LP5036 can control 36 LEDs LP5030 can control 30 LEDs LP5024 can control 24 LEDs LP5018 can control 18 LEDs The device has the ability to group LED output into control banks so