Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-21 Thread David Rientjes
On Mon, 19 May 2014, Vlastimil Babka wrote: > Fix a (spurious) build warning: > > mm/compaction.c:860:15: warning: ‘next_free_pfn’ may be used uninitialized in > this function [-Wmaybe-uninitialized] > > Seems like the compiler cannot prove that exiting the for loop without > updating >

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-21 Thread David Rientjes
On Mon, 19 May 2014, Vlastimil Babka wrote: Fix a (spurious) build warning: mm/compaction.c:860:15: warning: ‘next_free_pfn’ may be used uninitialized in this function [-Wmaybe-uninitialized] Seems like the compiler cannot prove that exiting the for loop without updating next_free_pfn

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-19 Thread Vlastimil Babka
I wonder why nobody complained about the build warning... sorry. 8< From: Vlastimil Babka Date: Mon, 19 May 2014 12:02:38 +0200 Subject: mm-compaction-avoid-rescanning-pageblocks-in-isolate_freepages-fix MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding:

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-19 Thread Vlastimil Babka
I wonder why nobody complained about the build warning... sorry. 8 From: Vlastimil Babka vba...@suse.cz Date: Mon, 19 May 2014 12:02:38 +0200 Subject: mm-compaction-avoid-rescanning-pageblocks-in-isolate_freepages-fix MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-12 Thread Joonsoo Kim
On Mon, May 12, 2014 at 11:09:25AM +0200, Vlastimil Babka wrote: > On 05/08/2014 07:28 AM, Joonsoo Kim wrote: > >On Wed, May 07, 2014 at 02:09:10PM +0200, Vlastimil Babka wrote: > >>The compaction free scanner in isolate_freepages() currently remembers PFN > >>of > >>the highest pageblock where

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-12 Thread Vlastimil Babka
On 05/08/2014 07:28 AM, Joonsoo Kim wrote: On Wed, May 07, 2014 at 02:09:10PM +0200, Vlastimil Babka wrote: The compaction free scanner in isolate_freepages() currently remembers PFN of the highest pageblock where it successfully isolates, to be used as the starting pageblock for the next

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-12 Thread Vlastimil Babka
On 05/08/2014 07:28 AM, Joonsoo Kim wrote: On Wed, May 07, 2014 at 02:09:10PM +0200, Vlastimil Babka wrote: The compaction free scanner in isolate_freepages() currently remembers PFN of the highest pageblock where it successfully isolates, to be used as the starting pageblock for the next

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-12 Thread Joonsoo Kim
On Mon, May 12, 2014 at 11:09:25AM +0200, Vlastimil Babka wrote: On 05/08/2014 07:28 AM, Joonsoo Kim wrote: On Wed, May 07, 2014 at 02:09:10PM +0200, Vlastimil Babka wrote: The compaction free scanner in isolate_freepages() currently remembers PFN of the highest pageblock where it

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-09 Thread Michal Nazarewicz
On Wed, May 07 2014, Vlastimil Babka wrote: > The compaction free scanner in isolate_freepages() currently remembers PFN of > the highest pageblock where it successfully isolates, to be used as the > starting pageblock for the next invocation. The rationale behind this is that > page migration

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-09 Thread Michal Nazarewicz
On Wed, May 07 2014, Vlastimil Babka wrote: The compaction free scanner in isolate_freepages() currently remembers PFN of the highest pageblock where it successfully isolates, to be used as the starting pageblock for the next invocation. The rationale behind this is that page migration might

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-07 Thread Joonsoo Kim
On Wed, May 07, 2014 at 02:09:10PM +0200, Vlastimil Babka wrote: > The compaction free scanner in isolate_freepages() currently remembers PFN of > the highest pageblock where it successfully isolates, to be used as the > starting pageblock for the next invocation. The rationale behind this is that

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-07 Thread David Rientjes
On Wed, 7 May 2014, Vlastimil Babka wrote: > The compaction free scanner in isolate_freepages() currently remembers PFN of > the highest pageblock where it successfully isolates, to be used as the > starting pageblock for the next invocation. The rationale behind this is that > page migration

[PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-07 Thread Vlastimil Babka
The compaction free scanner in isolate_freepages() currently remembers PFN of the highest pageblock where it successfully isolates, to be used as the starting pageblock for the next invocation. The rationale behind this is that page migration might return free pages to the allocator when migration

[PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-07 Thread Vlastimil Babka
The compaction free scanner in isolate_freepages() currently remembers PFN of the highest pageblock where it successfully isolates, to be used as the starting pageblock for the next invocation. The rationale behind this is that page migration might return free pages to the allocator when migration

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-07 Thread David Rientjes
On Wed, 7 May 2014, Vlastimil Babka wrote: The compaction free scanner in isolate_freepages() currently remembers PFN of the highest pageblock where it successfully isolates, to be used as the starting pageblock for the next invocation. The rationale behind this is that page migration might

Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages

2014-05-07 Thread Joonsoo Kim
On Wed, May 07, 2014 at 02:09:10PM +0200, Vlastimil Babka wrote: The compaction free scanner in isolate_freepages() currently remembers PFN of the highest pageblock where it successfully isolates, to be used as the starting pageblock for the next invocation. The rationale behind this is that