Re: [PATCH v2 2/2] net: phy: adin: implement Energy Detect Powerdown mode via phy-tunable

2019-09-04 Thread Ardelean, Alexandru
On Wed, 2019-09-04 at 22:03 +0200, Andrew Lunn wrote: > [External] > > On Wed, Sep 04, 2019 at 07:23:22PM +0300, Alexandru Ardelean wrote: > > This driver becomes the first user of the kernel's `ETHTOOL_PHY_EDPD` > > phy-tunable feature. > > EDPD is also enabled by default on PHY config_init, but

Re: [PATCH v2 2/2] net: phy: adin: implement Energy Detect Powerdown mode via phy-tunable

2019-09-04 Thread Andrew Lunn
On Wed, Sep 04, 2019 at 07:23:22PM +0300, Alexandru Ardelean wrote: > This driver becomes the first user of the kernel's `ETHTOOL_PHY_EDPD` > phy-tunable feature. > EDPD is also enabled by default on PHY config_init, but can be disabled via > the phy-tunable control. > > When enabling EDPD, it's a

[PATCH v2 2/2] net: phy: adin: implement Energy Detect Powerdown mode via phy-tunable

2019-09-04 Thread Alexandru Ardelean
This driver becomes the first user of the kernel's `ETHTOOL_PHY_EDPD` phy-tunable feature. EDPD is also enabled by default on PHY config_init, but can be disabled via the phy-tunable control. When enabling EDPD, it's also a good idea (for the ADIN PHYs) to enable TX periodic pulses, so that in cas