Re: [PATCH v2 2/2] nvme-pci: Allow PCI bus-level PM to be used if ASPM is disabled

2019-08-09 Thread Rafael J. Wysocki
On Fri, Aug 9, 2019 at 6:47 AM Bjorn Helgaas wrote: > > On Thu, Aug 08, 2019 at 10:41:56PM +0200, Rafael J. Wysocki wrote: > > On Thu, Aug 8, 2019, 20:39 Bjorn Helgaas wrote: > > > On Thu, Aug 08, 2019 at 04:47:45PM +0200, Rafael J. Wysocki wrote: > > > > On Thu, Aug 8, 2019 at 3:43 PM Bjorn Helg

Re: [PATCH v2 2/2] nvme-pci: Allow PCI bus-level PM to be used if ASPM is disabled

2019-08-08 Thread Bjorn Helgaas
On Thu, Aug 08, 2019 at 10:41:56PM +0200, Rafael J. Wysocki wrote: > On Thu, Aug 8, 2019, 20:39 Bjorn Helgaas wrote: > > On Thu, Aug 08, 2019 at 04:47:45PM +0200, Rafael J. Wysocki wrote: > > > On Thu, Aug 8, 2019 at 3:43 PM Bjorn Helgaas wrote: > > > > On Thu, Aug 08, 2019 at 12:10:06PM +0200, R

Re: [PATCH v2 2/2] nvme-pci: Allow PCI bus-level PM to be used if ASPM is disabled

2019-08-08 Thread Rafael J. Wysocki
On Thu, Aug 8, 2019, 20:39 Bjorn Helgaas wrote: > > On Thu, Aug 08, 2019 at 04:47:45PM +0200, Rafael J. Wysocki wrote: > > On Thu, Aug 8, 2019 at 3:43 PM Bjorn Helgaas wrote: > > > On Thu, Aug 08, 2019 at 12:10:06PM +0200, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > > > > >

RE: [PATCH v2 2/2] nvme-pci: Allow PCI bus-level PM to be used if ASPM is disabled

2019-08-08 Thread Mario.Limonciello
> This is more meaningful to you than to most people because "applying > the standard PCI PM" doesn't tell us what that means in terms of the > device. Presumably it has something to do with a D-state transition? > I *assume* a suspend might involve the D0 -> D3hot transition you > mention below?

Re: [PATCH v2 2/2] nvme-pci: Allow PCI bus-level PM to be used if ASPM is disabled

2019-08-08 Thread Keith Busch
On Thu, Aug 08, 2019 at 01:39:54PM -0500, Bjorn Helgaas wrote: > On Thu, Aug 08, 2019 at 04:47:45PM +0200, Rafael J. Wysocki wrote: > > On Thu, Aug 8, 2019 at 3:43 PM Bjorn Helgaas wrote: > > > > > IIUC the NVMe device will go to the desired package idle state if > > > the link is in L0s or L1, b

Re: [PATCH v2 2/2] nvme-pci: Allow PCI bus-level PM to be used if ASPM is disabled

2019-08-08 Thread Bjorn Helgaas
On Thu, Aug 08, 2019 at 04:47:45PM +0200, Rafael J. Wysocki wrote: > On Thu, Aug 8, 2019 at 3:43 PM Bjorn Helgaas wrote: > > On Thu, Aug 08, 2019 at 12:10:06PM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > One of the modifications made by commit d916b1be94b6 ("nvme-pci

Re: [PATCH v2 2/2] nvme-pci: Allow PCI bus-level PM to be used if ASPM is disabled

2019-08-08 Thread Rafael J. Wysocki
On Thu, Aug 8, 2019 at 4:47 PM Rafael J. Wysocki wrote: > > On Thu, Aug 8, 2019 at 3:43 PM Bjorn Helgaas wrote: > > > > On Thu, Aug 08, 2019 at 12:10:06PM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > One of the modifications made by commit d916b1be94b6 ("nvme-pci: us

Re: [PATCH v2 2/2] nvme-pci: Allow PCI bus-level PM to be used if ASPM is disabled

2019-08-08 Thread Rafael J. Wysocki
On Thu, Aug 8, 2019 at 3:43 PM Bjorn Helgaas wrote: > > On Thu, Aug 08, 2019 at 12:10:06PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > One of the modifications made by commit d916b1be94b6 ("nvme-pci: use > > host managed power state for suspend") was adding a pci_save_stat

Re: [PATCH v2 2/2] nvme-pci: Allow PCI bus-level PM to be used if ASPM is disabled

2019-08-08 Thread Bjorn Helgaas
On Thu, Aug 08, 2019 at 12:10:06PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > One of the modifications made by commit d916b1be94b6 ("nvme-pci: use > host managed power state for suspend") was adding a pci_save_state() > call to nvme_suspend() in order to prevent the PCI bus-lev

[PATCH v2 2/2] nvme-pci: Allow PCI bus-level PM to be used if ASPM is disabled

2019-08-08 Thread Rafael J. Wysocki
From: Rafael J. Wysocki One of the modifications made by commit d916b1be94b6 ("nvme-pci: use host managed power state for suspend") was adding a pci_save_state() call to nvme_suspend() in order to prevent the PCI bus-level PM from being applied to the suspended NVMe devices, but if ASPM is not en