Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-08-14 Thread Vadym Kochan
Hi Srinivas, On Mon, Jun 15, 2020 at 12:06:11PM +0100, Srinivas Kandagatla wrote: > > > On 05/06/2020 11:53, Vadym Kochan wrote: > > > One of the example is atmel eeprom (at24), but there might be different > > > devices. > > > > > > But can you please explain what is the technical/conceptual i

Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-06-15 Thread Srinivas Kandagatla
On 05/06/2020 11:53, Vadym Kochan wrote: One of the example is atmel eeprom (at24), but there might be different devices. But can you please explain what is the technical/conceptual issue with this approach ? Thanks, I just I'd like to clarify if there is a way it can be acceptable. The pro

Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-06-05 Thread Vadym Kochan
Hi Srinivas, On Mon, Jun 01, 2020 at 01:27:49PM +0300, Vadym Kochan wrote: > On Mon, Jun 01, 2020 at 10:13:05AM +0100, Srinivas Kandagatla wrote: > > > > > > On 01/06/2020 10:03, Vadym Kochan wrote: > > > > > + > > > > > + nvmem = of_nvmem_device_get(np, NULL); > > > > > + if (IS_ERR(nvm

Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-06-01 Thread Vadym Kochan
On Mon, Jun 01, 2020 at 10:13:05AM +0100, Srinivas Kandagatla wrote: > > > On 01/06/2020 10:03, Vadym Kochan wrote: > > > > + > > > > + nvmem = of_nvmem_device_get(np, NULL); > > > > + if (IS_ERR(nvmem)) > > > > + return PTR_ERR(nvmem); > > > > + > > > TBH, this looks co

Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-06-01 Thread Srinivas Kandagatla
On 01/06/2020 10:03, Vadym Kochan wrote: + + nvmem = of_nvmem_device_get(np, NULL); + if (IS_ERR(nvmem)) + return PTR_ERR(nvmem); + TBH, this looks completely incorrect way to do this and misuse of nvmem consumer interface. Ideally nvmem provider driver should popul

Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-06-01 Thread Vadym Kochan
Hi, On Mon, Jun 01, 2020 at 09:50:52AM +0100, Srinivas Kandagatla wrote: > > > On 30/05/2020 00:04, Vadym Kochan wrote: > > ONIE is a small operating system, pre-installed on bare metal network > > switches, that provides an environment for automated provisioning. > > > > This system requires t

Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-06-01 Thread Srinivas Kandagatla
On 30/05/2020 00:04, Vadym Kochan wrote: ONIE is a small operating system, pre-installed on bare metal network switches, that provides an environment for automated provisioning. This system requires that NVMEM (EEPROM) device holds various system information (mac address, platform name, etc)

[PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-05-29 Thread Vadym Kochan
ONIE is a small operating system, pre-installed on bare metal network switches, that provides an environment for automated provisioning. This system requires that NVMEM (EEPROM) device holds various system information (mac address, platform name, etc) in a special TLV layout. The driver registers