Re: [PATCH v2 2/2] phy: qualcomm: usb: Add Super-Speed PHY driver

2019-01-30 Thread Jorge Ramirez
On 1/30/19 10:53, Jorge Ramirez wrote: >> +priv->vbus = devm_regulator_get_optional(priv->dev, "vbus"); > get_optional means that if vbus-supply is not found, rather than > returning a dummy regulator object this will fail with -ENODEV. on this subject, is it intentional that devm_reset_contr

Re: [PATCH v2 2/2] phy: qualcomm: usb: Add Super-Speed PHY driver

2019-01-30 Thread Jorge Ramirez
On 1/30/19 10:53, Jorge Ramirez wrote: > On 1/29/19 21:27, Bjorn Andersson wrote: >> On Tue 29 Jan 03:35 PST 2019, Jorge Ramirez-Ortiz wrote: >>> diff --git a/drivers/phy/qualcomm/phy-qcom-usb-ss.c >>> b/drivers/phy/qualcomm/phy-qcom-usb-ss.c >>> new file mode 100644 >>> index 000..e6ae96e >>>

Re: [PATCH v2 2/2] phy: qualcomm: usb: Add Super-Speed PHY driver

2019-01-30 Thread Jorge Ramirez
On 1/29/19 21:27, Bjorn Andersson wrote: > On Tue 29 Jan 03:35 PST 2019, Jorge Ramirez-Ortiz wrote: >> diff --git a/drivers/phy/qualcomm/phy-qcom-usb-ss.c >> b/drivers/phy/qualcomm/phy-qcom-usb-ss.c >> new file mode 100644 >> index 000..e6ae96e >> --- /dev/null >> +++ b/drivers/phy/qualcomm/ph

Re: [PATCH v2 2/2] phy: qualcomm: usb: Add Super-Speed PHY driver

2019-01-29 Thread Bjorn Andersson
On Tue 29 Jan 03:35 PST 2019, Jorge Ramirez-Ortiz wrote: > diff --git a/drivers/phy/qualcomm/phy-qcom-usb-ss.c > b/drivers/phy/qualcomm/phy-qcom-usb-ss.c > new file mode 100644 > index 000..e6ae96e > --- /dev/null > +++ b/drivers/phy/qualcomm/phy-qcom-usb-ss.c > @@ -0,0 +1,347 @@ > +// SPDX-Li

[PATCH v2 2/2] phy: qualcomm: usb: Add Super-Speed PHY driver

2019-01-29 Thread Jorge Ramirez-Ortiz
Driver to control the Synopsys SS PHY 1.0.0 implemeneted in QCS404 Based on Sriharsha Allenki's original code. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/phy/qualcomm/Kconfig | 11 ++ drivers/phy/qualcomm/Makefile | 1 + drivers/phy/qualcomm/phy-qcom-usb-ss.c | 347 +++