Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Dan Carpenter
On Wed, Feb 10, 2021 at 11:04:28AM -0800, Drew Fustini wrote: > On Wed, Feb 10, 2021 at 09:20:44PM +0300, Dan Carpenter wrote: > > Hi Drew, > > > > url: > > https://github.com/0day-ci/linux/commits/Drew-Fustini/pinctrl-pinmux-Add-pinmux-select-debugfs-file/20210210-160108 > > > > base: >

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Drew Fustini
On Wed, Feb 10, 2021 at 10:05:29PM +0300, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 07:39:16PM +0100, Geert Uytterhoeven wrote: > > Hi Dan, > > > > On Wed, Feb 10, 2021 at 7:21 PM Dan Carpenter > > wrote: > > > 99b2f99aa41aa7 Drew Fustini 2021-02-09 694buf = > > >

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Drew Fustini
On Wed, Feb 10, 2021 at 09:20:44PM +0300, Dan Carpenter wrote: > Hi Drew, > > url: > https://github.com/0day-ci/linux/commits/Drew-Fustini/pinctrl-pinmux-Add-pinmux-select-debugfs-file/20210210-160108 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Dan Carpenter
On Wed, Feb 10, 2021 at 07:39:16PM +0100, Geert Uytterhoeven wrote: > Hi Dan, > > On Wed, Feb 10, 2021 at 7:21 PM Dan Carpenter > wrote: > > 99b2f99aa41aa7 Drew Fustini 2021-02-09 694buf = > > devm_kzalloc(pctldev->dev, PINMUX_MAX_NAME * 2, GFP_KERNEL); > > 99b2f99aa41aa7 Drew Fustini

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Geert Uytterhoeven
Hi Dan, On Wed, Feb 10, 2021 at 7:21 PM Dan Carpenter wrote: > 99b2f99aa41aa7 Drew Fustini 2021-02-09 694buf = > devm_kzalloc(pctldev->dev, PINMUX_MAX_NAME * 2, GFP_KERNEL); > 99b2f99aa41aa7 Drew Fustini 2021-02-09 695if (!buf) > 99b2f99aa41aa7 Drew Fustini 2021-02-09 696

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Dan Carpenter
Hi Drew, url: https://github.com/0day-ci/linux/commits/Drew-Fustini/pinctrl-pinmux-Add-pinmux-select-debugfs-file/20210210-160108 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel config: i386-randconfig-m021-20210209 (attached as .config) compiler: gcc-9

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Drew Fustini
On Wed, Feb 10, 2021 at 11:56:49AM +0200, Andy Shevchenko wrote: > On Wed, Feb 10, 2021 at 9:50 AM Drew Fustini wrote: > > > > Add "pinmux-select" to debugfs which will activate a function and group > > when 2 integers " " are written to > > the file. The write operation pinmux_select() handles

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Andy Shevchenko
On Wed, Feb 10, 2021 at 9:50 AM Drew Fustini wrote: > > Add "pinmux-select" to debugfs which will activate a function and group > when 2 integers " " are written to > the file. The write operation pinmux_select() handles this by checking > if fsel and gsel are valid selectors and then calling

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Geert Uytterhoeven
Hi Drew, On Wed, Feb 10, 2021 at 8:50 AM Drew Fustini wrote: > Add "pinmux-select" to debugfs which will activate a function and group > when 2 integers " " are written to > the file. The write operation pinmux_select() handles this by checking > if fsel and gsel are valid selectors and then

[PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-09 Thread Drew Fustini
Add "pinmux-select" to debugfs which will activate a function and group when 2 integers " " are written to the file. The write operation pinmux_select() handles this by checking if fsel and gsel are valid selectors and then calling ops->set_mux(). The existing "pinmux-functions" debugfs file