Re: [PATCH v2 2/2] pmbus: ltc2978: add regulator gating

2014-08-25 Thread Guenter Roeck
On Sun, Aug 24, 2014 at 08:30:16AM -0500, Alan Tull wrote: > On Sat, Aug 23, 2014 at 10:10 AM, Guenter Roeck wrote: > > On 08/22/2014 02:45 PM, Mark Brown wrote: > >> > >> On Fri, Aug 22, 2014 at 04:11:34PM -0500, at...@opensource.altera.com > >> wrote: > >>> > >>> From: Alan Tull > >>> > >>> Add

Re: [PATCH v2 2/2] pmbus: ltc2978: add regulator gating

2014-08-24 Thread Alan Tull
On Sat, Aug 23, 2014 at 10:10 AM, Guenter Roeck wrote: > On 08/22/2014 02:45 PM, Mark Brown wrote: >> >> On Fri, Aug 22, 2014 at 04:11:34PM -0500, at...@opensource.altera.com >> wrote: >>> >>> From: Alan Tull >>> >>> Add regulator with support for enabling or disabling all >>> supplies. >> >> >>

Re: [PATCH v2 2/2] pmbus: ltc2978: add regulator gating

2014-08-23 Thread Mark Brown
On Sat, Aug 23, 2014 at 08:10:16AM -0700, Guenter Roeck wrote: > Sorry I didn't have time to review the code myself. I'll have > to check the datasheet about turning regulators on and off. > Using page 0xff for the lm2978 looks wrong, as the chip supports > up to 8 channels which should be control

Re: [PATCH v2 2/2] pmbus: ltc2978: add regulator gating

2014-08-23 Thread Guenter Roeck
On 08/22/2014 02:45 PM, Mark Brown wrote: On Fri, Aug 22, 2014 at 04:11:34PM -0500, at...@opensource.altera.com wrote: From: Alan Tull Add regulator with support for enabling or disabling all supplies. Reviwed-by: Mark Brown though it still looks like you should be able to create generic f

Re: [PATCH v2 2/2] pmbus: ltc2978: add regulator gating

2014-08-22 Thread Mark Brown
On Fri, Aug 22, 2014 at 04:11:34PM -0500, at...@opensource.altera.com wrote: > From: Alan Tull > > Add regulator with support for enabling or disabling all > supplies. Reviwed-by: Mark Brown though it still looks like you should be able to create generic functions for the operations. signatu

[PATCH v2 2/2] pmbus: ltc2978: add regulator gating

2014-08-22 Thread atull
From: Alan Tull Add regulator with support for enabling or disabling all supplies. Signed-off-by: Alan Tull v2: Remove '#include ' Kconfig fixes Remove hardwired regulator_init_data --- drivers/hwmon/pmbus/Kconfig |7 + drivers/hwmon/pmbus/ltc2978.c | 60 +++