Re: [PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-06-29 Thread Thierry Reding
On Thu, Jun 18, 2015 at 09:58:59PM +0800, Yingjoe Chen wrote: > On Thu, 2015-06-18 at 18:19 +0800, YH Huang wrote: > > On Fri, 2015-06-12 at 12:20 +0200, Thierry Reding wrote: > > > > +/* Shift log2(PWM_PERIOD_MAX + 1) as divisor */ > > > > +#define PWM_PERIOD_BIT_SHIFT 12 > > > > > > I wasn't v

Re: [PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-06-29 Thread Thierry Reding
On Thu, Jun 18, 2015 at 06:19:44PM +0800, YH Huang wrote: > On Fri, 2015-06-12 at 12:20 +0200, Thierry Reding wrote: > > On Thu, May 21, 2015 at 09:29:24PM +0800, YH Huang wrote: [...] > > > +#define DISP_PWM_CON_1 0x14 > > > +#define PWM_PERIOD_MASK 0xfff > > > +#define PWM_PERI

Re: [PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-06-18 Thread Yingjoe Chen
On Thu, 2015-06-18 at 18:19 +0800, YH Huang wrote: > On Fri, 2015-06-12 at 12:20 +0200, Thierry Reding wrote: > > > +/* Shift log2(PWM_PERIOD_MAX + 1) as divisor */ > > > +#define PWM_PERIOD_BIT_SHIFT 12 > > > > I wasn't very clear about this in my earlier review, so let me try to > > explain

Re: [PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-06-18 Thread YH Huang
On Fri, 2015-06-12 at 12:20 +0200, Thierry Reding wrote: > On Thu, May 21, 2015 at 09:29:24PM +0800, YH Huang wrote: > > Add display PWM driver support to modify backlight for MT8173. > > > > Signed-off-by: YH Huang > > --- > > drivers/pwm/Kconfig| 10 ++ > > drivers/pwm/Makefile

Re: [PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-06-18 Thread YH Huang
On Fri, 2015-06-12 at 12:25 +0200, Thierry Reding wrote: > On Thu, May 21, 2015 at 09:29:24PM +0800, YH Huang wrote: > > Add display PWM driver support to modify backlight for MT8173. > > The driver also claims compatibility with MT6595, so you should mention > that here as well. Also please be mo

Re: [PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-06-12 Thread Thierry Reding
On Thu, May 21, 2015 at 09:29:24PM +0800, YH Huang wrote: > Add display PWM driver support to modify backlight for MT8173. The driver also claims compatibility with MT6595, so you should mention that here as well. Also please be more verbose in the commit message. You should mention things like ho

Re: [PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-06-12 Thread Thierry Reding
On Thu, May 21, 2015 at 09:29:24PM +0800, YH Huang wrote: > Add display PWM driver support to modify backlight for MT8173. > > Signed-off-by: YH Huang > --- > drivers/pwm/Kconfig| 10 ++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-mtk-disp.c | 228 >

[PATCH v2 2/2] pwm: add MediaTek display PWM driver support

2015-05-21 Thread YH Huang
Add display PWM driver support to modify backlight for MT8173. Signed-off-by: YH Huang --- drivers/pwm/Kconfig| 10 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-mtk-disp.c | 228 + 3 files changed, 239 insertions(+) create mode 1006