Re: [PATCH v2 2/2] regmap: soundwire: fix Kconfig select/depend issue

2019-05-06 Thread Pierre-Louis Bossart
On 5/5/19 11:40 PM, Mark Brown wrote: On Fri, May 03, 2019 at 09:32:53AM -0500, Pierre-Louis Bossart wrote: As I mentioned it'll compile the bus even if there is no user for it, but it's your call: alignment or optimization. You can have both. Alignment is a requirement. If you want to

Re: [PATCH v2 2/2] regmap: soundwire: fix Kconfig select/depend issue

2019-05-06 Thread Mark Brown
On Fri, May 03, 2019 at 09:32:53AM -0500, Pierre-Louis Bossart wrote: > As I mentioned it'll compile the bus even if there is no user for it, but > it's your call: alignment or optimization. You can have both. Alignment is a requirement. If you want to optimize this then it'd be better to

Re: [PATCH v2 2/2] regmap: soundwire: fix Kconfig select/depend issue

2019-05-03 Thread Pierre-Louis Bossart
On 5/2/19 11:39 PM, Mark Brown wrote: On Fri, Apr 19, 2019 at 02:46:49PM -0500, Pierre-Louis Bossart wrote: config REGMAP_SOUNDWIRE tristate - depends on SOUNDWIRE_BUS + select SOUNDWIRE_BUS This now makes _SOUNDWIRE different to all the other bus types; if this is a

Re: [PATCH v2 2/2] regmap: soundwire: fix Kconfig select/depend issue

2019-05-02 Thread Mark Brown
On Fri, Apr 19, 2019 at 02:46:49PM -0500, Pierre-Louis Bossart wrote: > config REGMAP_SOUNDWIRE > tristate > - depends on SOUNDWIRE_BUS > + select SOUNDWIRE_BUS This now makes _SOUNDWIRE different to all the other bus types; if this is a good change then surely the same thing

Re: [PATCH v2 2/2] regmap: soundwire: fix Kconfig select/depend issue

2019-04-22 Thread Vinod Koul
On 19-04-19, 14:46, Pierre-Louis Bossart wrote: > The mechanism should be > > config CODEC_XYX_SDW >depends on SOUNDWIRE >select REGMAP_SOUNDWIRE > > config REGMAP_SOUNDWIRE >select SOUNDWIRE_BUS > > SOUNDWIRE_BUS can be independently selected by the SOC driver. The SOC

[PATCH v2 2/2] regmap: soundwire: fix Kconfig select/depend issue

2019-04-19 Thread Pierre-Louis Bossart
The mechanism should be config CODEC_XYX_SDW depends on SOUNDWIRE select REGMAP_SOUNDWIRE config REGMAP_SOUNDWIRE select SOUNDWIRE_BUS SOUNDWIRE_BUS can be independently selected by the SOC driver. The SOC driver should not know or care about REGMAP_SOUNDWIRE. Fixes: