Re: [PATCH v2 2/2] rtc: sprd: Add Spreadtrum RTC driver

Hi Alexandre, On 9 November 2017 at 09:26, Alexandre Belloni wrote: > Hi, > > On 08/11/2017 at 17:16:15 +0800, Baolin Wang wrote: >> +static int sprd_rtc_read_time(struct device *dev, struct rtc_time *tm) >> +{ >> + struct sprd_rtc *rtc =

Re: [PATCH v2 2/2] rtc: sprd: Add Spreadtrum RTC driver

Hi Alexandre, On 9 November 2017 at 09:26, Alexandre Belloni wrote: > Hi, > > On 08/11/2017 at 17:16:15 +0800, Baolin Wang wrote: >> +static int sprd_rtc_read_time(struct device *dev, struct rtc_time *tm) >> +{ >> + struct sprd_rtc *rtc = dev_get_drvdata(dev); >> + time64_t secs; >> +

Re: [PATCH v2 2/2] rtc: sprd: Add Spreadtrum RTC driver

Hi, On 08/11/2017 at 17:16:15 +0800, Baolin Wang wrote: > +static int sprd_rtc_read_time(struct device *dev, struct rtc_time *tm) > +{ > + struct sprd_rtc *rtc = dev_get_drvdata(dev); > + time64_t secs; > + int ret; > + I would have expected a check for SPRD_RTC_POWER_RESET_FLAG

Re: [PATCH v2 2/2] rtc: sprd: Add Spreadtrum RTC driver

Hi, On 08/11/2017 at 17:16:15 +0800, Baolin Wang wrote: > +static int sprd_rtc_read_time(struct device *dev, struct rtc_time *tm) > +{ > + struct sprd_rtc *rtc = dev_get_drvdata(dev); > + time64_t secs; > + int ret; > + I would have expected a check for SPRD_RTC_POWER_RESET_FLAG

[PATCH v2 2/2] rtc: sprd: Add Spreadtrum RTC driver

This patch adds the Spreadtrum RTC driver, which embedded in the Spreadtrum SC27xx series PMICs. Signed-off-by: Baolin Wang --- Changes since v1: - Change file name. - Should depend on the MFD parent. - Add more help documentation. - Remove regmap wrapper

[PATCH v2 2/2] rtc: sprd: Add Spreadtrum RTC driver

This patch adds the Spreadtrum RTC driver, which embedded in the Spreadtrum SC27xx series PMICs. Signed-off-by: Baolin Wang --- Changes since v1: - Change file name. - Should depend on the MFD parent. - Add more help documentation. - Remove regmap wrapper functions. - Modify the mothod of