Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-01-20 Thread Al Cooper
I took another look at using the DMA framework for this and I still don't think it fits. The problem is that the DMA hardware is so tightly coupled to the 8250 UART hardware that a generic DMA model where a DMA engine will read the data from the UART data register when Data Ready is asserted and tr

Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-01-20 Thread Greg Kroah-Hartman
On Wed, Jan 20, 2021 at 07:09:46PM +0200, Andy Shevchenko wrote: > On Wed, Jan 20, 2021 at 7:05 PM Greg Kroah-Hartman > wrote: > > On Wed, Jan 20, 2021 at 06:47:52PM +0200, Andy Shevchenko wrote: > > > On Tue, Jan 19, 2021 at 8:16 PM Florian Fainelli > > > wrote: > > > > On 1/19/2021 7:21 AM, An

Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-01-20 Thread Andy Shevchenko
On Wed, Jan 20, 2021 at 7:05 PM Greg Kroah-Hartman wrote: > On Wed, Jan 20, 2021 at 06:47:52PM +0200, Andy Shevchenko wrote: > > On Tue, Jan 19, 2021 at 8:16 PM Florian Fainelli > > wrote: > > > On 1/19/2021 7:21 AM, Andy Shevchenko wrote: > > > > On Fri, Jan 15, 2021 at 11:19 PM Al Cooper wrot

Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-01-20 Thread Greg Kroah-Hartman
On Wed, Jan 20, 2021 at 06:47:52PM +0200, Andy Shevchenko wrote: > On Tue, Jan 19, 2021 at 8:16 PM Florian Fainelli wrote: > > On 1/19/2021 7:21 AM, Andy Shevchenko wrote: > > > On Fri, Jan 15, 2021 at 11:19 PM Al Cooper wrote: > > >> > > >> Add a UART driver for the new Broadcom 8250 based STB U

Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-01-20 Thread Andy Shevchenko
On Tue, Jan 19, 2021 at 8:16 PM Florian Fainelli wrote: > On 1/19/2021 7:21 AM, Andy Shevchenko wrote: > > On Fri, Jan 15, 2021 at 11:19 PM Al Cooper wrote: > >> > >> Add a UART driver for the new Broadcom 8250 based STB UART. The new > >> UART is backward compatible with the standard 8250, but h

Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-01-19 Thread Florian Fainelli
On 1/19/2021 7:21 AM, Andy Shevchenko wrote: > On Fri, Jan 15, 2021 at 11:19 PM Al Cooper wrote: >> >> Add a UART driver for the new Broadcom 8250 based STB UART. The new >> UART is backward compatible with the standard 8250, but has some >> additional features. The new features include a high

Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-01-19 Thread Andy Shevchenko
On Fri, Jan 15, 2021 at 11:19 PM Al Cooper wrote: > > Add a UART driver for the new Broadcom 8250 based STB UART. The new > UART is backward compatible with the standard 8250, but has some > additional features. The new features include a high accuracy baud > rate clock system and DMA support. > >

Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-01-19 Thread Greg Kroah-Hartman
On Mon, Jan 18, 2021 at 03:32:57PM -0500, Al Cooper wrote: > On Mon, Jan 18, 2021 at 12:45 PM Greg Kroah-Hartman > wrote: > > > > On Fri, Jan 15, 2021 at 04:15:43PM -0500, Al Cooper wrote: > > > Add a UART driver for the new Broadcom 8250 based STB UART. The new > > > UART is backward compatible w

Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-01-18 Thread Al Cooper
On Mon, Jan 18, 2021 at 12:45 PM Greg Kroah-Hartman wrote: > > On Fri, Jan 15, 2021 at 04:15:43PM -0500, Al Cooper wrote: > > Add a UART driver for the new Broadcom 8250 based STB UART. The new > > UART is backward compatible with the standard 8250, but has some > > additional features. The new fe

Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-01-18 Thread Greg Kroah-Hartman
On Fri, Jan 15, 2021 at 04:15:43PM -0500, Al Cooper wrote: > Add a UART driver for the new Broadcom 8250 based STB UART. The new > UART is backward compatible with the standard 8250, but has some > additional features. The new features include a high accuracy baud > rate clock system and DMA suppor

[PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-01-15 Thread Al Cooper
Add a UART driver for the new Broadcom 8250 based STB UART. The new UART is backward compatible with the standard 8250, but has some additional features. The new features include a high accuracy baud rate clock system and DMA support. The driver will use the new optional BAUD MUX clock to select t