Re: [PATCH v2 2/2] soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_read_aux_data()

2018-09-17 Thread Stephen Boyd
Quoting Jordan Crouse (2018-09-17 14:14:14) > On Mon, Sep 17, 2018 at 01:40:07PM -0700, Stephen Boyd wrote: > > + vals = cmd_db_read_aux_data(id, &len); > > /* > >* The data comes back as an array of unsigned shorts so adjust the > >* count accordingly > >*/ > > -

Re: [PATCH v2 2/2] soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_read_aux_data()

2018-09-17 Thread Jordan Crouse
On Mon, Sep 17, 2018 at 01:40:07PM -0700, Stephen Boyd wrote: > Let's change the function signature to return the pointer to memory or > an error pointer on failure, and take an argument that lets us return > the size of the aux data read. This way we can remove the > cmd_db_read_aux_data_len() API

[PATCH v2 2/2] soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_read_aux_data()

2018-09-17 Thread Stephen Boyd
Let's change the function signature to return the pointer to memory or an error pointer on failure, and take an argument that lets us return the size of the aux data read. This way we can remove the cmd_db_read_aux_data_len() API entirely and also get rid of the memcpy operation from cmd_db to the