Re: [PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-28 Thread Li Zefan
>>> static int __trace_define_field(struct list_head *head, const char *type, >>> const char *name, int offset, int size, >>> int is_signed, int filter_type) >>> @@ -120,13 +123,16 @@ static int __trace_define_field(struct list_head >>>

Re: [PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-28 Thread Li Zefan
static int __trace_define_field(struct list_head *head, const char *type, const char *name, int offset, int size, int is_signed, int filter_type) @@ -120,13 +123,16 @@ static int __trace_define_field(struct list_head *head, const char

Re: [PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-27 Thread Borislav Petkov
On Sat, Jul 27, 2013 at 07:35:38AM -0400, Steven Rostedt wrote: > But you know me. I LOVE macros! I'll say. Btw, I wouldn't wonder if you start sending patches for the gcc C preprocessor because it evaluates your macro voodoo too slow. :-) -- Regards/Gruss, Boris. Sent from a fat crate

Re: [PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-27 Thread Steven Rostedt
On Sat, 2013-07-27 at 10:45 +0200, Borislav Petkov wrote: > > > > + field->filter_type = filter_type; > > > field->offset = offset; > > > field->size = size; > > > - field->is_signed = is_signed; > > > + field->is_signed = !!is_signed; > > > + > > > + VERIFY_SIZE(filter_type); > > > +

Re: [PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-27 Thread Borislav Petkov
On Fri, Jul 26, 2013 at 11:47:22PM -0400, Steven Rostedt wrote: > On Sat, 2013-07-27 at 11:32 +0800, Li Zefan wrote: > > > struct event_filter { > > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > > index 7d85429..d72694d 100644 > > --- a/kernel/trace/trace_events.c > >

Re: [PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-27 Thread Borislav Petkov
On Fri, Jul 26, 2013 at 11:47:22PM -0400, Steven Rostedt wrote: On Sat, 2013-07-27 at 11:32 +0800, Li Zefan wrote: struct event_filter { diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 7d85429..d72694d 100644 --- a/kernel/trace/trace_events.c +++

Re: [PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-27 Thread Steven Rostedt
On Sat, 2013-07-27 at 10:45 +0200, Borislav Petkov wrote: + field-filter_type = filter_type; field-offset = offset; field-size = size; - field-is_signed = is_signed; + field-is_signed = !!is_signed; + + VERIFY_SIZE(filter_type); + VERIFY_SIZE(offset); +

Re: [PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-27 Thread Borislav Petkov
On Sat, Jul 27, 2013 at 07:35:38AM -0400, Steven Rostedt wrote: But you know me. I LOVE macros! I'll say. Btw, I wouldn't wonder if you start sending patches for the gcc C preprocessor because it evaluates your macro voodoo too slow. :-) -- Regards/Gruss, Boris. Sent from a fat crate

Re: [PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-26 Thread Steven Rostedt
On Sat, 2013-07-27 at 11:32 +0800, Li Zefan wrote: > struct event_filter { > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index 7d85429..d72694d 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -106,6 +106,9 @@

[PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-26 Thread Li Zefan
Use bit fields, and the size of struct ftrace_event_field can be shrunk from 48 bytes to 40 bytes on 64bit kernel. slab_name active_obj nr_obj size obj_per_slab - ftrace_event_field 1105 1105 48 85 (before) ftrace_event_field 1224 1224

[PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-26 Thread Li Zefan
Use bit fields, and the size of struct ftrace_event_field can be shrunk from 48 bytes to 40 bytes on 64bit kernel. slab_name active_obj nr_obj size obj_per_slab - ftrace_event_field 1105 1105 48 85 (before) ftrace_event_field 1224 1224

Re: [PATCH v2 2/2] tracing: Shrink the size of struct ftrace_event_field

2013-07-26 Thread Steven Rostedt
On Sat, 2013-07-27 at 11:32 +0800, Li Zefan wrote: struct event_filter { diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 7d85429..d72694d 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -106,6 +106,9 @@