Re: [PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx

Guenter Roeck writes: >> +writel(WD_CONFIG_XTAL_IN, dev->base + WD_CONFIG); > > What happens if the DISABLE bit was previously set (assuming > that DISABLE means that the watchdog is disabled) ? > > Concern I guess would be the combination of DISABLE being set > and WD_COUNTER at a value !=

Re: [PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx

On 11/18/2015 09:55 AM, Mans Rullgard wrote: This adds support for the Sigma Designs SMP86xx/SMP87xx family built-in watchdog. Signed-off-by: Mans Rullgard --- Changes: - combine start and ping functions - use watchdog_init_timeout() - calculate max timeout from clock rate - add get_timeleft

Re: [PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx

On 11/18/2015 09:55 AM, Mans Rullgard wrote: This adds support for the Sigma Designs SMP86xx/SMP87xx family built-in watchdog. Signed-off-by: Mans Rullgard --- Changes: - combine start and ping functions - use watchdog_init_timeout() - calculate max timeout from clock rate -

Re: [PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx

Guenter Roeck writes: >> +writel(WD_CONFIG_XTAL_IN, dev->base + WD_CONFIG); > > What happens if the DISABLE bit was previously set (assuming > that DISABLE means that the watchdog is disabled) ? > > Concern I guess would be the combination of DISABLE being set > and

[PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx

This adds support for the Sigma Designs SMP86xx/SMP87xx family built-in watchdog. Signed-off-by: Mans Rullgard --- Changes: - combine start and ping functions - use watchdog_init_timeout() - calculate max timeout from clock rate - add get_timeleft callback - check if already running on startup -

[PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx

This adds support for the Sigma Designs SMP86xx/SMP87xx family built-in watchdog. Signed-off-by: Mans Rullgard --- Changes: - combine start and ping functions - use watchdog_init_timeout() - calculate max timeout from clock rate - add get_timeleft callback - check if already